Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky CI builds #213

Merged
merged 3 commits into from Apr 9, 2020
Merged

Flaky CI builds #213

merged 3 commits into from Apr 9, 2020

Conversation

jglick
Copy link
Member

@jglick jglick commented Apr 9, 2020

From #192, #208, and master.

@jglick jglick added the chore Reduces future maintenance label Apr 9, 2020
@jglick jglick marked this pull request as ready for review April 9, 2020 15:27
@jglick jglick changed the title Flakes Flaky CI builds Apr 9, 2020
@jglick jglick merged commit ac7f195 into jenkinsci:master Apr 9, 2020
@jglick jglick deleted the flakes branch April 9, 2020 18:13
@basil
Copy link
Member

basil commented Mar 2, 2022

PRs like this that consume an unmerged and/or unreleased upstream change need to remain in draft state until the upstream change is merged and released.

@jglick
Copy link
Member Author

jglick commented Mar 2, 2022

Referring to jenkinsci/plugin-compat-tester#228? Yes in general. At least as of jenkinsci/plugin-compat-tester#255 the unreleased upstream change is easier to identify.

For now we are still stuck on jenkinsci/plugin-compat-tester#345 since none of us has had time to work on a proper supportable patch or even make the current patches be activated by some sort of experimental flag. #657

@basil
Copy link
Member

basil commented Mar 2, 2022

#657 could have been avoided had we refrained from consuming an unmerged and/or unreleased upstream change in a non-draft PR.

@jglick
Copy link
Member Author

jglick commented Mar 2, 2022

Yes, it could; we prioritized getting bom builds working reliably and handling ongoing plugin releases.

@basil basil mentioned this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces future maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants