Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CD #320

Merged
merged 4 commits into from Nov 23, 2021
Merged

Enable CD #320

merged 4 commits into from Nov 23, 2021

Conversation

jglick
Copy link
Member

@jglick jglick commented Nov 23, 2021

Builds on top of #255 after jenkins-infra/repository-permissions-updater#2103. I lack write access to this repo so I would not be able to help troubleshoot issues.

.github/workflows/cd.yaml Show resolved Hide resolved
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-deploy-plugin</artifactId>
<configuration>
<skip>true</skip>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figure the module structure of this repo is uninteresting to consumers—they only wish to use the CLI artifact.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

his is incorrect - anyone that wants to write hooks needs to consume the model. May aw well just push everything and be done.

@jglick
Copy link
Member Author

jglick commented Nov 23, 2021

I lack write access to this repo

Or rather, it seems I have write but lack admin.

@timja
Copy link
Member

timja commented Nov 23, 2021

I lack write access to this repo

Or rather, it seems I have write but lack admin.

Changed

@jglick jglick merged commit ff4d8c2 into jenkinsci:master Nov 23, 2021
@jglick jglick deleted the cd branch November 23, 2021 19:10
@jglick jglick mentioned this pull request Nov 29, 2021
jtnord added a commit to jtnord/plugin-compat-tester that referenced this pull request Sep 30, 2022
@jtnord jtnord mentioned this pull request Sep 30, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants