Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump antlr4.version from 4.5 to 4.9.1 #174

Merged
merged 3 commits into from Feb 10, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 6, 2021

Bumps antlr4.version from 4.5 to 4.9.1.
Updates antlr4-runtime from 4.5 to 4.9.1

Release notes

Sourced from antlr4-runtime's releases.

4.9.1 bug fix release

Issues fixed

Pull requests grouped by target

csharp target

cpp target

go target

java target

javascript target

python2 target

python3 target

Contributors

4.9 New dart target, bug fixes, small enhancements

New DART target

... (truncated)

Commits
  • 5c2b686 [maven-release-plugin] prepare release 4.9.1
  • 00b98dd fix another typo in appveyor.yml trying to get PHP to work.
  • 82113bd set runtime/PHP name properly
  • 547fd7c add php to travis script again
  • 615d76d add clone for php to travis script
  • 3b90a43 Revert "rm php from appveyor"
  • 41f3f49 rm submodule pull, clone instead
  • 16b6e49 set compat in swift
  • c5fbf63 update doc
  • 534d95b rm php from travis
  • Additional commits viewable in compare view

Updates antlr4-maven-plugin from 4.5 to 4.9.1

Release notes

Sourced from antlr4-maven-plugin's releases.

4.9.1 bug fix release

Issues fixed

Pull requests grouped by target

csharp target

cpp target

go target

java target

javascript target

python2 target

python3 target

Contributors

4.9 New dart target, bug fixes, small enhancements

New DART target

... (truncated)

Commits
  • 5c2b686 [maven-release-plugin] prepare release 4.9.1
  • 00b98dd fix another typo in appveyor.yml trying to get PHP to work.
  • 82113bd set runtime/PHP name properly
  • 547fd7c add php to travis script again
  • 615d76d add clone for php to travis script
  • 3b90a43 Revert "rm php from appveyor"
  • 41f3f49 rm submodule pull, clone instead
  • 16b6e49 set compat in swift
  • c5fbf63 update doc
  • 534d95b rm php from travis
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@jvz
Copy link
Member

jvz commented Feb 3, 2021

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/antlr4.version-4.9.1 branch from 3343a33 to b6f4339 Compare February 3, 2021 16:47
@jvz
Copy link
Member

jvz commented Feb 3, 2021

Hmm, test failures, and those tests cover code that uses this dependency.

@jvz
Copy link
Member

jvz commented Feb 10, 2021

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/antlr4.version-4.9.1 branch from b6f4339 to 2a79237 Compare February 10, 2021 16:25
Bumps `antlr4.version` from 4.5 to 4.9.1.

Updates `antlr4-runtime` from 4.5 to 4.9.1
- [Release notes](https://github.com/antlr/antlr4/releases)
- [Changelog](https://github.com/antlr/antlr4/blob/master/CHANGES.txt)
- [Commits](antlr/antlr4@4.5...4.9.1)

Updates `antlr4-maven-plugin` from 4.5 to 4.9.1
- [Release notes](https://github.com/antlr/antlr4/releases)
- [Changelog](https://github.com/antlr/antlr4/blob/master/CHANGES.txt)
- [Commits](antlr/antlr4@4.5...4.9.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/antlr4.version-4.9.1 branch from 2a79237 to 6d02216 Compare February 10, 2021 16:35
@jvz
Copy link
Member

jvz commented Feb 10, 2021

Oh wow, digging in to this test failure is pretty funny. The test expects id == 4foo to be an invalid expression, but something has changed behind the scenes in antlr such that this expression is now being interpreted as equivalent to id == 4f as in the floating point literal 4. Not sure why the oo suffix is being ignored, but the changelog may have some hints.

Signed-off-by: Matt Sicker <boards@gmail.com>
Signed-off-by: Matt Sicker <boards@gmail.com>
@jvz
Copy link
Member

jvz commented Feb 10, 2021

I can't seem to get that to be stricter without breaking existing parsing. Oh well, we can just remove it.

@jvz
Copy link
Member

jvz commented Feb 10, 2021

@dependabot merge

@dependabot dependabot bot merged commit 09ebf49 into master Feb 10, 2021
@dependabot dependabot bot deleted the dependabot/maven/antlr4.version-4.9.1 branch February 10, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant