Skip to content

travis: upgrade c++ build to focal & llvm 10 #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2020

Conversation

felixn
Copy link
Contributor

@felixn felixn commented Nov 30, 2020

Alternative PR to #2908, upgrading only the c++ build

The first build shows that openjdk8 is not available with Ubuntu focal:
https://travis-ci.org/github/antlr/antlr4/builds/746825671

The command "~/bin/install-jdk.sh --target "/home/travis/openjdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "GPL" --cacerts" failed and exited with 3 during .

The second build shows the issues in the C++ runtime:
https://travis-ci.org/github/antlr/antlr4/builds/746909160

In file included from /tmp/BaseCppTest-main-1606808268300/TLexer.cpp:5:
In file included from /tmp/BaseCppTest-main-1606808268300/TLexer.h:7:
In file included from /home/travis/build/antlr/antlr4/runtime-testsuite/target/classes/Cpp/runtime/src/antlr4-runtime.h:126:
/home/travis/build/antlr/antlr4/runtime-testsuite/target/classes/Cpp/runtime/src/misc/InterpreterDataReader.h:20:5: error: call to implicitly-deleted default constructor of 'dfa::Vocabulary'
    InterpreterData() {}; // For invalid content.
    ^
/home/travis/build/antlr/antlr4/runtime-testsuite/target/classes/Cpp/runtime/src/Vocabulary.h:25:5: note: explicitly defaulted function was implicitly deleted here
    Vocabulary() = default;
    ^
/home/travis/build/antlr/antlr4/runtime-testsuite/target/classes/Cpp/runtime/src/Vocabulary.h:185:36: note: default constructor of 'Vocabulary' is implicitly deleted because field '_literalNames' of const-qualified type 'const std::vector<std::string>' (aka 'const vector<basic_string<char> >') would not be initialized
    std::vector<std::string> const _literalNames;
                                   ^
1 error generated.

The third build passes:
https://travis-ci.org/github/antlr/antlr4/builds/747024792?utm_source=github_status&utm_medium=notification

@felixn
Copy link
Contributor Author

felixn commented Dec 2, 2020

This is ready to merge, from my point of view.

@mike-lischke
Copy link
Member

@parrt That's a minimal change, so I believe it is safe to merge.

@parrt
Copy link
Member

parrt commented Dec 2, 2020

Hmm... I think it would feel better if it didn't also change the Java version being used to test.

@mike-lischke
Copy link
Member

All tests passed, so what suprise do you expect by that change?

@parrt
Copy link
Member

parrt commented Dec 2, 2020

well, we claim java 7 compatibility. Seems like we should stick to that version for tests.

@felixn
Copy link
Contributor Author

felixn commented Dec 3, 2020

Hi Terence,

unfortunately, the current Ubuntu LTS (20.04 / focal) Travis image does not support openjkd8 - that's why the first build failed.

Also, from my point of view, it's actually a good thing if we test with some varying Java versions (C++ with Java 11, others with Java 8) to increase test coverage.

Plus, Java 8 is "almost" EOL: "Java SE 8 has gone through the End of Public Updates process for legacy releases."
https://www.oracle.com/java/technologies/java-se-support-roadmap.html

But you're the big boss ;)
If you want, I can look for a Ubuntu version that supports the old Java 8 and the newer LLVM releases.

Cheers Felix

@parrt
Copy link
Member

parrt commented Dec 3, 2020

Well if there is no java 8 then I guess we have no choice. Ha ha. Merging. thanks for your efforts.

@parrt parrt merged commit c278c1d into antlr:master Dec 3, 2020
@felixn felixn deleted the travis-use-newer-versions-cpp branch December 3, 2020 18:56
@parrt parrt added this to the 4.9.1 milestone Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants