Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py3 Runtime: distribute the tests #2971

Merged
merged 2 commits into from Jan 1, 2021

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Nov 26, 2020

Hello,

I'm packaging the Python 3 runtime for Debian. It would be useful to us if the source distribution (on https://pypi.org/project/antlr4-python3-runtime/ or elsewhere) contained the tests.

I've modified it so that the tests are now part of the installed Python module; with this PR users can confirm their installation with python3 -m unittest antlr4.test

Many thanks,

@mr-c
Copy link
Contributor Author

mr-c commented Nov 26, 2020

I just learned that pulling the tests out of the sdist was a recent happening: #2911

Still, Debian would appreciate having the tests in the sdist.

@ericvergnaud
Copy link
Contributor

there are hardly any tests in the python runtime itself
the real tests are part of antlr4-complete, a java package
why do you need the tests?

@mr-c
Copy link
Contributor Author

mr-c commented Nov 26, 2020

@ericvergnaud We'd like to confirm that the runtime works when we build the Debian package, and that it the produced Debian package continues to work even if there are changes to our Python 3 package or other dependencies.

@mr-c
Copy link
Contributor Author

mr-c commented Nov 26, 2020

If there are tests of the Python3 runtime available only on the Java side, then I can co-ordinate with the Debian volunteers who maintain https://tracker.debian.org/pkg/antlr4 ; but we would still appreciate making use of any pure-Python dedicated tests that exist for the Python3 runtime.

@mr-c
Copy link
Contributor Author

mr-c commented Nov 27, 2020

@ericvergnaud I've reworked this PR to only include the test directory in the sourceball, without including the tests in the antlr4 Python package. I think this approach avoids the issue the #2911 fixed while still distributing the tests when the next update is published to PyPI.

As a bonus, I've retained the change that includes the pygrun script as part of the installation process.

Please let me know if this is more acceptable, thanks!

@ericvergnaud ericvergnaud merged commit 491cb78 into antlr:master Jan 1, 2021
@mr-c mr-c deleted the py3runtime_test_dist branch January 1, 2021 09:26
@mr-c
Copy link
Contributor Author

mr-c commented Jan 1, 2021

Thanks!

@parrt parrt added this to the 4.9.1 milestone Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants