Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netstandard 2.0 build #2984

Closed
JBaltika opened this issue Dec 1, 2020 · 10 comments · Fixed by #2987
Closed

netstandard 2.0 build #2984

JBaltika opened this issue Dec 1, 2020 · 10 comments · Fixed by #2987

Comments

@JBaltika
Copy link

JBaltika commented Dec 1, 2020

Hi guys,
I think it's long overdue to create a real netStandard 2.0 build without the runtime redirect hell. Its two different notions - can run on specific version and its builded specifically for particular netstandard version....
Screenshot01

Just a thought

Sincerely Jim

@ericvergnaud
Copy link
Contributor

ericvergnaud commented Dec 1, 2020 via email

@KvanTTT
Copy link
Member

KvanTTT commented Dec 1, 2020

I think it makes to upgrade the minimum version to netstandard2.0 or at least to add netstandard2.0, netstandard2.1 to TagetFramemeworks

@KvanTTT
Copy link
Member

KvanTTT commented Dec 1, 2020

Also, maybe it makes sense to drop support of mono, vs2013, and especially net framework 3.5? I guess there are a small number of users but support consumes time and effort.

@KvanTTT
Copy link
Member

KvanTTT commented Dec 2, 2020

@ericvergnaud what do you think about such changes? Are you approving them?

@ericvergnaud
Copy link
Contributor

I work on Mac, and I'm not seeing net standard 2 in the list of of target frameworks in VS8.8.2 for the current project.
But it seems feasible to use that with new projects, see https://docs.microsoft.com/en-us/dotnet/core/tutorials/library-with-visual-studio-mac
So if someone is willing to invest the effort, I am supportive.
(users needing to stick to .Net 3.5 can stick to 4.9)

@KvanTTT
Copy link
Member

KvanTTT commented Dec 2, 2020

I work on Mac, and I'm not seeing net standard 2 in the list of target frameworks in VS8.8.2 for the current project.

It's quite strange because netstandard2.0 is very mature and stable for the current time. But anyway it's possible to publish the package both as netstandard2.0 and as netstandard2.1.

users needing to stick to .Net 3.5 can stick to 4.9

It does not make sense to support net 4.9 if netstandard2.0 is supported because the latest supports all dotnet runtimes since 4.6.1, see the table.

@ericvergnaud
Copy link
Contributor

I meant ANTLR 4.9

@ericvergnaud
Copy link
Contributor

@KvanTTT
Copy link
Member

KvanTTT commented Dec 2, 2020

Users with net35 will be able to use the older version of ANTLR. Users with version >= net461 will be able to use any version of ANTLR.

This was referenced Dec 2, 2020
@KvanTTT
Copy link
Member

KvanTTT commented Dec 28, 2020

Seems it cannot be done via the UI:

It's not very important because it can be done via changing csproj file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants