Update to webpack 3

[HairyRabbit]

closes #699
closes #705

[mastilver]

Thank you for that PR :)

Good call on EXTRACT_PLUGIN_VERSION 👍

Now we just have to wait for: webpack-contrib/extract-text-webpack-plugin#540 and we will be good to go!

[joshwiens]

@mastilver - 3.0.0-beta.3 is out on npm. Any issues, ping me in Slack or on Twitter. Either will make it to my cell phone.

[filipesilva]

@d3viant0ne I can't seem to find html-webpack-plugin@3.0.0-beta.0 on npm, was it published?

[mastilver]

@filipesilva it's extract-text-webpack-plugin@3.0.0-beta.0

[filipesilva]

Ah, apologies, I misunderstoord 👍

[mastilver]

@yuffiy Do you mind updating your PR to get the latest extract-text-webpack-plugin?

I'm unable to do it atm

[mastilver]

@yuffiy @d3viant0ne Thank you for your work! 👍

@jantimon I let you squash, merge and release that :)

[jantimon]

It's full backwards compatible so we can just release it as 2.29 right?

[mastilver]

@jantimon Yep, no tests for webpack@1/2 have been changed, so I would think there is not breaking changes

[jantimon]

Why did you remove the following files?
node_modules/html-webpack-plugin/index.js
node_modules/html-webpack-plugin/lib/loader.js

[jantimon]

Thank you so much @d3viant0ne @yuffiy @mastilver for your work :) released as 2.29

[damianobarbati]

Should this fix the ERROR in TypeError: Cannot read property 'request' of undefined error we currently have with webpack 3?

[damianobarbati]

Working combo for me:

        "extract-text-webpack-plugin": "3.0.0-beta.3",
        "html-webpack-plugin": "^2.29.0",
        "webpack": "^3.0.0",

[Kingwl]

it's very helpful to me!

[HairyRabbit]

Thanks all

[chrisui]

Just a heads up it'd be good to add a git release tag so it shows up in the github releases page. Took me a while to realise 2.28.0 isn't the latest and was confused for a while! :)

Thanks for the work on this great plugin!

[zowers]

@chrisui for some reason commit 2cc10df is not tagged

[mastilver]

@chrisui done

[chrisui]

@mastilver ⭐️

[lock]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.