Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Webpack3 support #706

Closed
wants to merge 4 commits into from

Conversation

yveskaufmann
Copy link

@yveskaufmann yveskaufmann commented Jun 20, 2017

Added initial support for Webpack 3, as descripted in #699. Additionally enabled the ExtractTextPlugin.extract override also for Webpack Version 3.x.x.

The Travis builds for Webpack 3 will still fail. Because the tests & examples depend on the appcache-webpack-plugin and extract-text-webpack-plugin which both not supporting webpack 3 yet. Fortunately, the webpack 3 support of extract-text-webpack-plugin is in progress.

- add webpack@3 to peerDependencies
- add webpack@3 environment for travis build
- enable ExtractTextPlugin.extract override also for webpack 3.x.x
- .travis.yml define a separate env variable for the extract_text_plugin version
@vramana vramana mentioned this pull request Jun 20, 2017
@jantimon
Copy link
Owner

We have to regenerate the examples for webpack 3 to satisfy travis

@yveskaufmann
Copy link
Author

yveskaufmann commented Jun 20, 2017

Yeah, i know but the generation of the examples fails because the installation of webpack@3 and extract-text-webpack-plugin@2.1.2 failed.

The reason for that are:

355 npm ERR! peerinvalid The package webpack@3.0.0 does not satisfy its siblings' peerDependencies requirements!
356 npm ERR! peerinvalid Peer appcache-webpack-plugin@1.3.0 wants webpack@>=0.11 <2.0.0 || >=2.1.0-beta.13 <3.0.0

I have changed the travis build to make this obviously.

@jantimon
Copy link
Owner

Closed because of #707

@lock
Copy link

lock bot commented May 31, 2018

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants