Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow webpack@3 #704

Closed
wants to merge 2 commits into from
Closed

Allow webpack@3 #704

wants to merge 2 commits into from

Conversation

vramana
Copy link

@vramana vramana commented Jun 19, 2017

No description provided.

@mastilver
Copy link
Collaborator

@vramana Thank you for your PR, please see my comment there: #699 (comment)

package.json Outdated
@@ -63,6 +63,6 @@
"toposort": "^1.0.0"
},
"peerDependencies": {
"webpack": "1 || ^2 || ^2.1.0-beta || ^2.2.0-rc"
"webpack": "1 || ^2 || ^2.1.0-beta || ^2.2.0-rc" || ^3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close the string

@vramana
Copy link
Author

vramana commented Jun 20, 2017

@mastilver Fixed it.

@vramana
Copy link
Author

vramana commented Jun 20, 2017

It seems #706 and #707 does a better job than my PR. Hence I am closing my PR

@vramana vramana closed this Jun 20, 2017
@vramana vramana deleted the patch-1 branch June 20, 2017 06:57
@lock
Copy link

lock bot commented May 31, 2018

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants