-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created new UnwrapStrToUpper mutator #551
Closed
zf2timo
wants to merge
16
commits into
infection:master
from
zf2timo:feature/strtoupper-mutator-2edition
Closed
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
76da5c4
Created new UnwrapStrToUpper mutator
zf2timo 24dd6a9
Fixed code style
zf2timo 245a23c
Fixed code style
zf2timo 719ff2d
Added additional unit test
zf2timo d2824cc
Do not mutate interfaces (#548)
sanmai 61e42da
Enhancement: Implement UnwrapArrayReplaceRecursive mutator (#545)
localheinz e33dee5
Enhancement: Implement UnwrapArrayCombine mutator (#550)
localheinz 2771903
Enhancement: Unwrap all available arguments to array_map() (#553)
localheinz 998293e
Implement schema validation for the config file (#524)
sidz a5441ae
Permit for occasional skipped E2E test due to Composer's failure to i…
sanmai 697df4d
Created new UnwrapStrToUpper mutator
zf2timo bf7db4e
Fixed code style
zf2timo 2dca708
Fixed code style
zf2timo bfc1c35
Added additional unit test
zf2timo 1c383e1
Mutator shouldn't match other functions starting with strto
zf2timo 4c39872
Merge branch 'feature/strtoupper-mutator-2edition' of github.com:zf2t…
zf2timo File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
<?php | ||
/** | ||
* This code is licensed under the BSD 3-Clause License. | ||
* | ||
* Copyright (c) 2017-2018, Maks Rafalko | ||
* All rights reserved. | ||
* | ||
* Redistribution and use in source and binary forms, with or without | ||
* modification, are permitted provided that the following conditions are met: | ||
* | ||
* * Redistributions of source code must retain the above copyright notice, this | ||
* list of conditions and the following disclaimer. | ||
* | ||
* * Redistributions in binary form must reproduce the above copyright notice, | ||
* this list of conditions and the following disclaimer in the documentation | ||
* and/or other materials provided with the distribution. | ||
* | ||
* * Neither the name of the copyright holder nor the names of its | ||
* contributors may be used to endorse or promote products derived from | ||
* this software without specific prior written permission. | ||
* | ||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | ||
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE | ||
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE | ||
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | ||
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR | ||
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, | ||
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
*/ | ||
|
||
declare(strict_types=1); | ||
|
||
namespace Infection\Mutator\Unwrap; | ||
|
||
use PhpParser\Node; | ||
|
||
/** | ||
* @internal | ||
*/ | ||
final class UnwrapStrToUpper extends AbstractUnwrapMutator | ||
{ | ||
protected function getFunctionName(): string | ||
{ | ||
return 'strtoupper'; | ||
} | ||
|
||
protected function getParameterIndexes(Node $node): \Generator | ||
{ | ||
yield 0; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,177 @@ | ||
<?php | ||
/** | ||
* This code is licensed under the BSD 3-Clause License. | ||
* | ||
* Copyright (c) 2017-2018, Maks Rafalko | ||
* All rights reserved. | ||
* | ||
* Redistribution and use in source and binary forms, with or without | ||
* modification, are permitted provided that the following conditions are met: | ||
* | ||
* * Redistributions of source code must retain the above copyright notice, this | ||
* list of conditions and the following disclaimer. | ||
* | ||
* * Redistributions in binary form must reproduce the above copyright notice, | ||
* this list of conditions and the following disclaimer in the documentation | ||
* and/or other materials provided with the distribution. | ||
* | ||
* * Neither the name of the copyright holder nor the names of its | ||
* contributors may be used to endorse or promote products derived from | ||
* this software without specific prior written permission. | ||
* | ||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | ||
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE | ||
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE | ||
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | ||
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR | ||
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, | ||
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
*/ | ||
|
||
declare(strict_types=1); | ||
|
||
namespace Infection\Tests\Mutator\Unwrap; | ||
|
||
use Infection\Tests\Mutator\AbstractMutatorTestCase; | ||
|
||
/** | ||
* @internal | ||
*/ | ||
final class UnwrapStrToUpperTest extends AbstractMutatorTestCase | ||
{ | ||
/** | ||
* @dataProvider provideMutationCases | ||
*/ | ||
public function test_mutator($input, $expected = null): void | ||
{ | ||
$this->doTest($input, $expected); | ||
} | ||
|
||
public function provideMutationCases(): \Generator | ||
{ | ||
yield 'It mutates correctly when provided with an string' => [ | ||
<<<'PHP' | ||
<?php | ||
|
||
$a = strtoupper('infection'); | ||
PHP | ||
, | ||
<<<'PHP' | ||
<?php | ||
|
||
$a = 'infection'; | ||
PHP | ||
]; | ||
|
||
yield 'It mutates correctly when provided with a constant' => [ | ||
<<<'PHP' | ||
<?php | ||
|
||
$a = strtoupper(\Class_With_Const::Const); | ||
PHP | ||
, | ||
<<<'PHP' | ||
<?php | ||
|
||
$a = \Class_With_Const::Const; | ||
PHP | ||
]; | ||
|
||
yield 'It mutates correctly when a backslash is in front of strtoupper' => [ | ||
<<<'PHP' | ||
<?php | ||
|
||
$a = \strtoupper('infection'); | ||
PHP | ||
, | ||
<<<'PHP' | ||
<?php | ||
|
||
$a = 'infection'; | ||
PHP | ||
]; | ||
|
||
yield 'It does not mutate other array_ calls' => [ | ||
<<<'PHP' | ||
<?php | ||
|
||
$a = array_map('strtoupper', 'infection'); | ||
PHP | ||
]; | ||
|
||
yield 'It does not mutate functions named strtoupper' => [ | ||
<<<'PHP' | ||
<?php | ||
|
||
function strtoupper($text) | ||
{ | ||
} | ||
PHP | ||
]; | ||
|
||
yield 'It mutates correctly within if statements' => [ | ||
<<<'PHP' | ||
<?php | ||
|
||
$a = 'infection'; | ||
if (strtoupper($a) === $a) { | ||
return true; | ||
} | ||
PHP | ||
, | ||
<<<'PHP' | ||
<?php | ||
|
||
$a = 'infection'; | ||
if ($a === $a) { | ||
return true; | ||
} | ||
PHP | ||
]; | ||
|
||
yield 'It mutates correctly when strtoupper is wrongly capitalized' => [ | ||
<<<'PHP' | ||
<?php | ||
|
||
$a = StrToUpper('infection'); | ||
PHP | ||
, | ||
<<<'PHP' | ||
<?php | ||
|
||
$a = 'infection'; | ||
PHP | ||
]; | ||
|
||
yield 'It mutates correctly when strtoupper uses another function as input' => [ | ||
<<<'PHP' | ||
<?php | ||
|
||
$a = strtoupper($foo->bar()); | ||
PHP | ||
, | ||
<<<'PHP' | ||
<?php | ||
|
||
$a = $foo->bar(); | ||
PHP | ||
]; | ||
|
||
yield 'It mutates correctly when provided with a more complex situation' => [ | ||
zf2timo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
<<<'PHP' | ||
<?php | ||
|
||
$a = array_map('strtoupper', strtoupper('infection')); | ||
PHP | ||
, | ||
<<<'PHP' | ||
<?php | ||
|
||
$a = array_map('strtoupper', 'infection'); | ||
PHP | ||
]; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha, I think this test case doesn't apply - can we remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it could be changed to "It does not mutate other strto calls"? Or adds this still no value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍