Run Infection on PHP 8.1. #1535

sidz · 2021-07-12T20:47:14Z

This PR:

Runs Infection on PHP 8.1.

sidz · 2021-07-12T21:12:58Z

latest release nikic/PHP-Parser still has an issue with parsing parameter passed by reference. https://github.com/infection/infection/pull/1535/checks?check_run_id=3050732900#step:7:79

Already fixed in master: nikic/PHP-Parser@c758510

waiting for release.

maks-rafalko · 2021-07-21T10:52:36Z

waiting for release.

https://github.com/nikic/PHP-Parser/releases/tag/v4.12.0

maks-rafalko · 2021-07-21T10:55:58Z

.github/workflows/autoreview.yaml

@@ -16,7 +16,7 @@ jobs:

    strategy:
      matrix:
-        php-version: ['7.4']


7.4 is still supported until 28 of November, 2021, and it's used by ~60% of Infection users, I think we should not get rid of it now.

Or, alternatively, if we want to get rid (personally, I'm ok with that) - we should bump the version in composer.json to ^8.0, here

https://github.com/infection/infection/blob/master/composer.json#L45

sanmai · 2021-07-22T01:35:25Z

.github/workflows/ci.yaml

      - name: Cache dependencies
        uses: actions/cache@v2
        with:
-          path: ${{ steps.composer-cache.outputs.dir }}
+          path: ~/.cache/composer


This won't work on Windows IIRC, and we're testing on Windows.

sidz · 2021-10-11T21:12:51Z

.github/workflows/ci.yaml

@@ -18,16 +18,15 @@ jobs:
      matrix:
        operating-system: [ubuntu-latest]
        php-version: ['7.4']
-        dependencies: ['']


no longer required as we got rid of --ignore-platform-req=php

sidz · 2021-10-11T21:15:09Z

tests/phpunit/Fixtures/Finder/MockSplFileInfo.php

+use Symfony\Component\Finder\SplFileInfo;
+use ReturnTypeWillChange;
+
+final class MockSplFileInfo extends SplFileInfo


copy idea from symfony repo.

sidz · 2021-10-11T21:15:45Z

tests/phpunit/IterableCounterTest.php

@@ -43,7 +44,7 @@ final class IterableCounterTest extends TestCase
 {
    public function test_it_does_not_count_when_not_asked(): void
    {
-        $iterator = $this->createMock(Iterator::class);
+        $iterator = new ArrayIterator();


use real iterator to avoid deprecation notes in PHP 8.1

sidz · 2021-10-11T21:17:32Z

finally ready for review 🤓

maks-rafalko

mostly questions, besides that - great work 👍

maks-rafalko · 2021-10-12T05:53:02Z

composer.json

@@ -67,8 +67,7 @@
        "webmozart/path-util": "^2.3"
    },
    "conflict": {
-        "phpunit/php-code-coverage": ">9 <9.1.4",
-        "symfony/console": "=4.1.5"


could you please clarify why was it removed?

we support 4.1.9 or higher: https://github.com/infection/infection/blob/master/composer.json#L61

maks-rafalko · 2021-10-12T05:56:34Z

src/Mutator/Unwrap/AbstractUnwrapMutator.php

@@ -58,6 +58,10 @@ abstract class AbstractUnwrapMutator implements Mutator
    final public function mutate(Node $node): iterable
    {
        foreach ($this->getParameterIndexes($node) as $index) {
+            if ($node->args[$index] instanceof Node\VariadicPlaceholder) {


Not sure I got this change. Do we need a test (at least for 1 such case) that will proof it's needed?

due to changes in PHP-Parser 4.13. Look at 3rd option in the Added group (https://github.com/nikic/PHP-Parser/releases):

p.s. looks like we can use getArgs() instead of this trick. I'll give it a try

such conditions is required to avoid issues like https://github.com/infection/infection/pull/1535/checks?check_run_id=3867799614#step:7:10

also can't use getArgs due to https://github.com/infection/infection/pull/1535/checks?check_run_id=3867799614#step:7:32

p.s. so reverted to previous commit.

maks-rafalko · 2021-10-12T05:57:29Z

tests/phpunit/FileSystem/SourceFileFilterTest.php

     */
    private function createSplFileInfosTraversable(array $filePaths): Traversable
    {
        return take($filePaths)
-            ->map(function (string $filename) {
-                $traceMock = $this->createMock(SplFileInfo::class);


is it not working anymore? what's the reason of adding MockSpliFileInfo?

to avoid tons of deprecation notes in PHP 8.1. like: Return type of Mock_SplFileInfo_8d3a072c::getPath() should either be compatible with SplFileInfo::getPath(): string, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

unfortunately I can't give you a link to failed tests in our pipeline as they are not available.

maks-rafalko · 2021-10-13T06:54:28Z

@sidz could you please rebase? I think we should merge it to avoid conflicts and failed builds on master (enabled auto-merge)

… either be compatible with SplFileInfo::getPath() on 8.1

…t loses precision"

sidz · 2021-10-13T07:30:02Z

@maks-rafalko done

sidz · 2021-10-13T08:04:57Z

looks like Github has some issues with builds based on windows. Same on master

maks-rafalko · 2021-10-13T11:25:43Z

I've re-run builds and now they are green, seems like just an occasional issue on GHA

Thank you, @sidz

sidz marked this pull request as draft July 12, 2021 20:52

maks-rafalko reviewed Jul 21, 2021

View reviewed changes

sidz force-pushed the run-tests-on-php-8.1 branch from b18ce5e to 78d2432 Compare July 21, 2021 20:21

sanmai reviewed Jul 22, 2021

View reviewed changes

sidz force-pushed the run-tests-on-php-8.1 branch from 36516d1 to 0357aae Compare August 9, 2021 18:52

maks-rafalko mentioned this pull request Sep 19, 2021

CI does not run prefixed PHAR for e2e tests #1508

Closed

sidz force-pushed the run-tests-on-php-8.1 branch 2 times, most recently from e240bca to ae5911b Compare October 7, 2021 18:47

sidz force-pushed the run-tests-on-php-8.1 branch 7 times, most recently from b9d2d3c to bdc579b Compare October 11, 2021 20:34

sidz commented Oct 11, 2021

View reviewed changes

sidz self-assigned this Oct 11, 2021

sidz marked this pull request as ready for review October 11, 2021 21:16

sidz requested review from maks-rafalko and sanmai October 11, 2021 21:17

maks-rafalko reviewed Oct 12, 2021

View reviewed changes

sidz force-pushed the run-tests-on-php-8.1 branch from 347b567 to 25b8bae Compare October 12, 2021 08:44

maks-rafalko approved these changes Oct 12, 2021

View reviewed changes

maks-rafalko enabled auto-merge (squash) October 13, 2021 06:53

sidz added 16 commits October 13, 2021 10:10

Run Infection on PHP 8.1

282d7c7

update symfony deps, add ReturnTypeWillChange attribute

ac2bc4e

add check on VariadicPlaceholder

e378a28

remove conflict with symfony/console 4.1.5

008dbb8

try to fix Return type of Mock_SplFileInfo_8d3a072c::getPath() should…

a769111

… either be compatible with SplFileInfo::getPath() on 8.1

whitelist PHP 8.1 constants in scoper.inc.php

a871309

Add MockSplFileInfo mocks to work with Unit tests

012971b

Increase possible direct issues

1d9aa4d

fix another bunch of tests

347c4a3

export SYMFONY_DEPRECATIONS_HELPER env variable as part of CI pipeline

e4b0cb2

cast to int explicitly to avoid "Implicit conversion from float to in…

049e872

…t loses precision"

fix pipeline

ce7da6d

remove continue-on-error on PHP 8.1

32980c9

remove ignore-platform-req from pipeline

2eb658e

clean up pipeline

6ad8729

import ReturnTypeWillChange to use section

78c0f81

sidz force-pushed the run-tests-on-php-8.1 branch from fce6e4d to 78c0f81 Compare October 13, 2021 07:11

maks-rafalko merged commit 55446cf into master Oct 13, 2021

maks-rafalko deleted the run-tests-on-php-8.1 branch October 13, 2021 11:19

theofidry mentioned this pull request Dec 21, 2022

refactor(ci): Review the mutation testing workflow #1791

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run Infection on PHP 8.1. #1535

Run Infection on PHP 8.1. #1535

sidz commented Jul 12, 2021 •

edited

sidz commented Jul 12, 2021 •

edited

maks-rafalko commented Jul 21, 2021

maks-rafalko Jul 21, 2021

sidz Jul 21, 2021

sanmai Jul 22, 2021

sidz Oct 11, 2021

sidz Oct 11, 2021

sidz Oct 11, 2021

sidz commented Oct 11, 2021

maks-rafalko left a comment

maks-rafalko Oct 12, 2021

sidz Oct 12, 2021

maks-rafalko Oct 12, 2021

sidz Oct 12, 2021 •

edited

sidz Oct 12, 2021

maks-rafalko Oct 12, 2021

sidz Oct 12, 2021 •

edited

maks-rafalko commented Oct 13, 2021

sidz commented Oct 13, 2021

sidz commented Oct 13, 2021 •

edited

maks-rafalko commented Oct 13, 2021

Run Infection on PHP 8.1. #1535

Run Infection on PHP 8.1. #1535

Conversation

sidz commented Jul 12, 2021 • edited

sidz commented Jul 12, 2021 • edited

maks-rafalko commented Jul 21, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sidz commented Oct 11, 2021

maks-rafalko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sidz Oct 12, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sidz Oct 12, 2021 • edited

Choose a reason for hiding this comment

maks-rafalko commented Oct 13, 2021

sidz commented Oct 13, 2021

sidz commented Oct 13, 2021 • edited

maks-rafalko commented Oct 13, 2021

sidz commented Jul 12, 2021 •

edited

sidz commented Jul 12, 2021 •

edited

sidz Oct 12, 2021 •

edited

sidz Oct 12, 2021 •

edited

sidz commented Oct 13, 2021 •

edited