New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ci): Review the mutation testing workflow #1791
refactor(ci): Review the mutation testing workflow #1791
Conversation
|
||
- name: Collect coverage report | ||
run: | | ||
php vendor/phpunit/phpunit/phpunit --stop-on-failure \ | ||
SYMFONY_DEPRECATIONS_HELPER=disabled php vendor/phpunit/phpunit/phpunit --stop-on-failure \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because depending on the deprecations it can fail this build. It's not necessarily bad, but we already check for the deprecations in ci.yaml
. So having it here is redundant, and disabling it guaranteeing we get to the interesting part of that build which is running infection with coverage generated and with the badge API key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lemme know if that's a satisfying answer for you or you prefer to keep it
My understanding of that build was, from what I understand in #1365, to have a dedicated pipeline mimicking what a typical user pipeline may look like and testing our mutation badge feature. Over time this was slightly tweaked:
I think the build is still useful, but we now have a more comprehensive and diversified test suite to test the different OS, dependencies, code coverage reports and co in
ci.yaml
. Hence this build can be more scoped and from that simplified.Tried to switch to Xdebug. I was curious if there is a big time difference but in general I also know Xdebug is more accurate than pcov, so we may prefer this to enforce a specific MSI score.
Comparing with this build, we had:
At least from those results it doesn't look worth it.