Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI does not run prefixed PHAR for e2e tests #1508

Closed
maks-rafalko opened this issue Apr 25, 2021 · 1 comment
Closed

CI does not run prefixed PHAR for e2e tests #1508

maks-rafalko opened this issue Apr 25, 2021 · 1 comment
Labels
Critical

Comments

@maks-rafalko
Copy link
Member

Related and blocked by #1507

Previously, Travis compiled PHAR and executed E2E tests on our CI, founding all the issues related to prefixing and PHAR itself.

Now, GitHub Actions do not run E2E tests with prefixed PHAR. Because of that, we didn't find the issue described in #1507 and released the new 0.22.0 version without ability to generate PHAR.

When #1507 is resolved, we need add this logic back to GitHub Actions.
@maks-rafalko maks-rafalko mentioned this issue May 13, 2021
Merged
@maks-rafalko maks-rafalko mentioned this issue Jul 6, 2021
Closed
This was referenced Sep 6, 2021
Closed
Closed
@maks-rafalko
Copy link
Member Author

Now it does (#1568), but PHAR is still broken for PHP 7.4 (#1573), but I'm not too much concerned about it since we are going to get rid of PHP 7.4 support soon (#1535)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maks-rafalko