Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: revert to 2018 edition #847

Merged
merged 1 commit into from Dec 7, 2021
Merged

chore: revert to 2018 edition #847

merged 1 commit into from Dec 7, 2021

Conversation

davidpdrsn
Copy link
Member

Fixes #843

@akiradeveloper akiradeveloper mentioned this pull request Nov 25, 2021
Closed
@davidpdrsn davidpdrsn mentioned this pull request Nov 25, 2021
Merged
@takkuumi
Copy link

why？

@davidpdrsn
Copy link
Member Author

Because tonic is used in libraries that don’t want to require the latest version of Rust. Such as opentelemetry.

@davidpdrsn davidpdrsn merged commit 101f2f7 into master Dec 7, 2021
@davidpdrsn davidpdrsn deleted the 2018-edition branch December 7, 2021 08:49
davidpdrsn added a commit that referenced this pull request Dec 7, 2021
@davidpdrsn
chore: Prepare 0.6.2
c4fe446 
- Contains the revert to [rust 2018](#847).
- Bumps both tonic and tonic-build.
- tonic-build goes from 0.6.0 to 0.6.2 since there was no 0.6.1. I
  believe we want tonic and tonic-build versions to follow each other.
@davidpdrsn davidpdrsn mentioned this pull request Dec 7, 2021
Merged
davidpdrsn added a commit that referenced this pull request Dec 7, 2021
@davidpdrsn
chore: Prepare 0.6.2
2d9c74f 
- Contains the revert to [rust 2018](#847).
- Bumps both tonic and tonic-build.
- tonic-build goes from 0.6.0 to 0.6.2 since there was no 0.6.1. I
  believe we want tonic and tonic-build versions to follow each other.
davidpdrsn added a commit that referenced this pull request Dec 8, 2021
@davidpdrsn
chore: Prepare 0.6.2 (#860)
e78a2d8 
- Contains the revert to [rust 2018](#847).
- Bumps both tonic and tonic-build.
- tonic-build goes from 0.6.0 to 0.6.2 since there was no 0.6.1. I
  believe we want tonic and tonic-build versions to follow each other.
@matze matze mentioned this pull request Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olix0r olix0r olix0r approved these changes

@LucioFranco LucioFranco Awaiting requested review from LucioFranco

Assignees
No one assigned
Labels
A-tonic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.6.0: unannounced MSRV break
3 participants
@davidpdrsn @takkuumi @olix0r