Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version of auxiliary crates to crates.io with 2018 revert #902

Closed
matze opened this issue Feb 1, 2022 · 2 comments
Closed

Release version of auxiliary crates to crates.io with 2018 revert #902

matze opened this issue Feb 1, 2022 · 2 comments
Milestone

Comments

@matze
Copy link
Contributor

matze commented Feb 1, 2022

Bug Report

Crates

tonic-health, tonic-reflection, tonic-types, …

Description

Auxiliary crates that have not seen a new release (e.g. tonic-health 0.5, tonic-reflection 0.3, …) since #847 are incompatible with tonic 0.6.2 in builds that use an edition 2018-only compiler, i.e. anything lower than Rust 1.56.

Releasing new versions of these crates should mitigate this issue.

@matze matze changed the title Auxiliary crates are incompatible with with 0.6.2 Auxiliary crates are incompatible with 0.6.2 + edition 2018 Feb 1, 2022
@matze
Copy link
Contributor Author

matze commented Feb 4, 2022

Is there anything blocking minor releases for these crates? Performance issues are still unresolved in the current stable Rust compiler and this issue here effectively prevents us from upgrading tonic entirely without swallowing the cost of a newer Rust.

@LucioFranco
Copy link
Member

Oh yup this was a miss! If this is something still required I can try to get a patch release out otherwise I'd like to get these updated in the next release. As a workaround you should be able to use patching via git to overcome this issue since they are fixed on github.

@LucioFranco LucioFranco changed the title Auxiliary crates are incompatible with 0.6.2 + edition 2018 Release version of axuiliary crates to crates.io with 2018 revert Feb 16, 2022
@LucioFranco LucioFranco added this to the 0.7 milestone Feb 16, 2022
@matze matze changed the title Release version of axuiliary crates to crates.io with 2018 revert Release version of auxiliary crates to crates.io with 2018 revert Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants