New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tonic, prost, and friends #660
Update tonic, prost, and friends #660
Conversation
I'm working on getting the CLA signed. I work at Embark Studios which have contributed before so shouldn't be too hard 🤞 |
Codecov Report
@@ Coverage Diff @@
## main #660 +/- ##
=======================================
Coverage 71.39% 71.39%
=======================================
Files 101 101
Lines 8564 8564
=======================================
Hits 6114 6114
Misses 2450 2450
Continue to review full report at Codecov.
|
Thanks! may need to run |
I'm interested in this! |
Sorry for taking so long to finish this, but I have not forgotten about it 😅 However I've realized that tonic 0.6 switched to the 2021 edition which isn't compatible with opentelemetry's MSRV. So we have to move tonic back to 2018 first. I'm doing that here. |
63fba93
to
cdb3592
Compare
@davidpdrsn looks good just one clippy lint left looks like |
I just published tonic 0.6.2 which reverted to using rust 2018 so this can now be compatible with opentelemetry's MSRV. I'll update this PR tomorrow. |
The lint error from CI seems to be unrelated to these changes. Let me know if you want me to address them somehow. Otherwise this should be good to go now 😊 |
Thanks @davidpdrsn ! |
@davidpdrsn mind rebasing (or letting otel maintainers edit your branch so we can rebase for you)? The otel org has set all repos to require up to date branches to be merged unfortunately |
@jtescher doesn't seem like you can enable maintainer edits after creating the PR. I'll get this rebased within the next few days! |
@davidpdrsn ok thanks! |
@davidpdrsn the next release is coming soon. Do you have time to rebase this? (May need to open a new PR.) |
e09a986
to
d22fdf9
Compare
@djc I rebased just now and it went clean through. 🤞 for CI |
Updates tonic and tonic-build to 0.6 and prost, prost-build, and prost-types to 0.8.
When building this locally I get this error:
However I also get that
main
so not sure if its a an issue in my setup or a general issue.