Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain backtrace for TypeErrors in value change callback #584

Merged
merged 1 commit into from Sep 15, 2022
Merged

Retain backtrace for TypeErrors in value change callback #584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/core/value_observer.ts
View file
Open in desktop
Expand Up @@ -96,9 +96,11 @@ export class ValueObserver implements StringMapObserverDelegate {

changedMethod.call(this.receiver, value, oldValue)
} catch (error) {
if (!(error instanceof TypeError)) throw error
if (error instanceof TypeError) {
error.message = `Stimulus Value "${this.context.identifier}.${descriptor.name}" - ${error.message}`
}

throw new TypeError(`Stimulus Value "${this.context.identifier}.${descriptor.name}" - ${error.message}`)
throw error
}
}
}
Expand Down