Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain backtrace for TypeErrors in value change callback #584

Merged
merged 1 commit into from Sep 15, 2022
Merged

Retain backtrace for TypeErrors in value change callback #584

merged 1 commit into from Sep 15, 2022

Commits on Sep 12, 2022

  1. Retain backtrace for TypeErrors in value change callback 

    This code was originally added to provide better error messaging
for TypeErrors when assigning values.

Unfortunately throwing a new error object causes us to lose
the context (including stacktrace) of the original error,
making it harder to locate the source.

Changing the message and rethrowing the original error
retain that information.
    @elliotcm
    elliotcm committed Sep 12, 2022
    Copy the full SHA
    680818d View commit details
    Browse the repository at this point in the history