Retain backtrace for TypeErrors in value change callback #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was originally added to provide better error messaging for TypeErrors when assigning values. Unfortunately throwing a new error object causes us to lose the context (including stacktrace) of the original error, making it harder to locate the source. Changing the message and rethrowing the original error retain that information.
marcoroth
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was originally added to provide better error messaging for TypeErrors when assigning values.
Unfortunately throwing a new error object causes us to lose the context (including stacktrace) of the original error, making it harder to locate the source.
Changing the message and rethrowing the original error retain that information.
Before
After
Thanks to @marcoroth for help discussing this issue.