Don't set SO_REUSEPORT on Windows (#23947) [HZ-2213] #25378
Merged
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SO_REUSEADDR flag works as expected on POSIX platforms, but will cause indeterminate behaviors on Windows sockets. See: - jetty/jetty.project#6661 (comment) - learn.microsoft.com/en-us/windows/win32/winsock/using-so-reuseaddr-and-so-exclusiveaddruse#using-so_reuseaddr
ldziedziul
added
Type: Defect
Source: Internal
orcunc
approved these changes
Sep 6, 2023
TomaszGaweda
approved these changes
Sep 6, 2023
|
I am not sure if branching will cause performance hit; Even if so, it should be relatively small one, because those conditions will remain the same and C2 should have optimization options |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SO_REUSEADDR flag works as expected on POSIX platforms, but will cause indeterminate behaviors on Windows sockets.
See:
Fixes #23947
Fixes https://hazelcast.atlassian.net/browse/HZ-2213
Breaking changes (list specific methods/types/messages):
Checklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release NotesorNot Release Notes contentset@Nonnull/@Nullableannotations@sincetags in Javadoc