Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set SO_REUSEPORT on Windows (#23947) [HZ-2213] #25378

Merged
merged 1 commit into from Sep 7, 2023
Merged

Don't set SO_REUSEPORT on Windows (#23947) [HZ-2213] #25378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...ngine/src/main/java/com/hazelcast/internal/tpcengine/nio/NioAsyncServerSocketOptions.java
View file
Open in desktop
Expand Up @@ -18,12 +18,14 @@

import com.hazelcast.internal.tpcengine.Option;
import com.hazelcast.internal.tpcengine.net.AsyncSocketOptions;
import com.hazelcast.internal.tpcengine.util.OS;

import java.io.IOException;
import java.io.UncheckedIOException;
import java.net.SocketOption;
import java.net.StandardSocketOptions;
import java.nio.channels.ServerSocketChannel;
import java.util.Set;

import static com.hazelcast.internal.tpcengine.util.Preconditions.checkNotNull;

Expand All @@ -32,6 +34,7 @@
*/
public class NioAsyncServerSocketOptions implements AsyncSocketOptions {

private static final Set<SocketOption<?>> WINDOWS_UNSUPPORTED_OPTIONS = Set.of(StandardSocketOptions.SO_REUSEPORT);
private final ServerSocketChannel serverSocketChannel;

NioAsyncServerSocketOptions(ServerSocketChannel serverSocketChannel) {
Expand Down Expand Up @@ -59,7 +62,13 @@ public boolean isSupported(Option option) {
}

private boolean isSupported(SocketOption socketOption) {
return socketOption != null && serverSocketChannel.supportedOptions().contains(socketOption);
if (socketOption == null) {
return false;
}
if (OS.isWindows() && WINDOWS_UNSUPPORTED_OPTIONS.contains(socketOption)) {
return false;
}
return serverSocketChannel.supportedOptions().contains(socketOption);
}

@Override
Expand Down