Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set SO_REUSEPORT on Windows (#23947) [5.3.z] #25397

Merged
merged 1 commit into from Sep 7, 2023
Merged

Don't set SO_REUSEPORT on Windows (#23947) [5.3.z] #25397

merged 1 commit into from Sep 7, 2023

Conversation

ldziedziul
Copy link
Contributor

Backport of #25378

SO_REUSEADDR flag works as expected on POSIX platforms, but will cause indeterminate behaviors on Windows sockets.

See:

Fixes #23947
Fixes https://hazelcast.atlassian.net/browse/HZ-2213

Breaking changes (list specific methods/types/messages):

  • API
  • client protocol format
  • serialized form
  • snapshot format

Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Label Add to Release Notes or Not Release Notes content set
  • Request reviewers if possible
  • Send backports/forwardports if fix needs to be applied to past/future releases
  • New public APIs have @Nonnull/@Nullable annotations
  • New public APIs have @since tags in Javadoc

@ldziedziul ldziedziul added this to the 5.3.z milestone Sep 7, 2023
@ldziedziul ldziedziul self-assigned this Sep 7, 2023
@ldziedziul ldziedziul merged commit 19ac23a into hazelcast:5.3.z Sep 7, 2023
8 checks passed
@ldziedziul ldziedziul deleted the backport-pr-25378-5.3.z branch September 7, 2023 10:48
@degerhz degerhz modified the milestones: 5.3.z, 5.3.3 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomaszGaweda TomaszGaweda TomaszGaweda approved these changes

@orcunc orcunc orcunc approved these changes

@pveentjer pveentjer Awaiting requested review from pveentjer

Assignees

@ldziedziul ldziedziul

Labels
Module: TPC Not Release Notes content Source: Internal PR or issue was opened by an employee Team: Integration Type: Defect
Projects
None yet
Milestone
5.3.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ldziedziul @TomaszGaweda @orcunc @degerhz