UI/fix kmip role form #13585
Merged
UI/fix kmip role form #13585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leRow invocations
Monkeychip
reviewed
Jan 6, 2022
| @@ -1,4 +1,4 @@ | |||
| <InfoTableRow @label="Name" @value={{@model.name}} @data-test-alias-name={{true}} /> | |||
| <InfoTableRow @label="Name" @value={{@model.name}} data-test-alias-name={{true}} /> | |||
There was a problem hiding this comment.
Curious how that @data.... got in there!
There was a problem hiding this comment.
Probably an upgrade maybe even back to the big one in 1.7
There was a problem hiding this comment.
I think it was the latest ember upgrade. I considered find-replacing all the @data-test instances, but we have a few cases where it looks like they're actually supposed to work that way (eg. ToolbarSecretLink 😱)
Monkeychip
reviewed
Jan 6, 2022
| </InfoTableRow>`); | ||
|
|
||
| let block = document.querySelector('[data-test-value-div]').textContent.trim(); | ||
| assert.equal(block, 'Block content is here', 'renders block passed through'); | ||
| }); | ||
|
|
||
| test('Row renders when block content even if alwaysRender = false', async function (assert) { |
There was a problem hiding this comment.
Thank you for adding test coverage!
|
I was wondering how the layout thing was going to work when glimmerizing addon components. Looks like the template has to be moved along side the component file and it just works? |
hashishaw
added a commit
that referenced
this pull request
Jan 7, 2022
* Conflicts fixed * Fix info-table-row not rendering if alwaysRender=false and only block content present * use defaultFields for form and nonOperationFields for adapter * WIP: Move info table row template to addon component dir * Refactor InfoTableRow to glimmer component * Add changelog * passthrough attributes, change @data-test-x to data-test-x on InfoTableRow invocations
This was referenced Jan 7, 2022
heppu
pushed a commit
to heppu/vault
that referenced
this pull request
Jan 13, 2022
* Fix info-table-row not rendering if alwaysRender=false and only block content present * use defaultFields for form and nonOperationFields for adapter * WIP: Move info table row template to addon component dir * Refactor InfoTableRow to glimmer component * Add changelog * passthrough attributes, change @data-test-x to data-test-x on InfoTableRow invocations
joatmon08
pushed a commit
that referenced
this pull request
Jan 25, 2022
* Fix info-table-row not rendering if alwaysRender=false and only block content present * use defaultFields for form and nonOperationFields for adapter * WIP: Move info table row template to addon component dir * Refactor InfoTableRow to glimmer component * Add changelog * passthrough attributes, change @data-test-x to data-test-x on InfoTableRow invocations
qk4l
pushed a commit
to qk4l/vault
that referenced
this pull request
Feb 4, 2022
* Fix info-table-row not rendering if alwaysRender=false and only block content present * use defaultFields for form and nonOperationFields for adapter * WIP: Move info table row template to addon component dir * Refactor InfoTableRow to glimmer component * Add changelog * passthrough attributes, change @data-test-x to data-test-x on InfoTableRow invocations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, there was a bug where creating a KMIP role did not save any non-operator keys. There was also an issue where TLS info was not displayed on the show details page, due to an issue in InfoTableRow. As part of this work, I glimmerized InfoTableRow Component and added tests for various scenarios.
Before (key bits value does not save)
After
