New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/fix kmip role form #13585
Merged
Merged
UI/fix kmip role form #13585
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0ae6373
Fix info-table-row not rendering if alwaysRender=false and only block…
hashishaw 74ca2b0
use defaultFields for form and nonOperationFields for adapter
hashishaw e8828be
WIP: Move info table row template to addon component dir
hashishaw 80d88d5
Refactor InfoTableRow to glimmer component
hashishaw b15d34e
Add changelog
hashishaw cfef5f3
passthrough attributes, change @data-test-x to data-test-x on InfoTab…
hashishaw 9298027
Fix tests
hashishaw File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
```release-note:bug | ||
ui: Fixes issue saving KMIP role correctly | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
ui/app/templates/components/identity/item-alias/alias-details.hbs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
{{#if (or (has-block) this.isVisible)}} | ||
<div class="info-table-row" data-test-component="info-table-row" ...attributes> | ||
<div | ||
class="column is-one-quarter {{if this.hasLabelOverflow "label-overflow"}}" | ||
data-test-label-div | ||
{{did-insert this.calculateLabelOverflow}} | ||
> | ||
{{#if @label}} | ||
{{#if this.hasLabelOverflow}} | ||
<ToolTip @verticalPosition="below" @horizontalPosition="left" as |T|> | ||
<T.Trigger @tabindex={{false}}> | ||
<span class="is-label has-text-grey-dark" data-test-row-label={{@label}}>{{@label}}</span> | ||
</T.Trigger> | ||
<T.Content class="tool-tip"> | ||
<div class="box fit-content" data-test-label-tooltip> | ||
{{@label}} | ||
</div> | ||
</T.Content> | ||
</ToolTip> | ||
{{else}} | ||
<span class="is-label has-text-grey-dark" data-test-row-label={{@label}}>{{@label}}</span> | ||
{{/if}} | ||
{{#if @helperText}} | ||
<div> | ||
<span class="is-label helper-text has-text-grey">{{@helperText}}</span> | ||
</div> | ||
{{/if}} | ||
{{else}} | ||
<Icon @name="minus" /> | ||
{{/if}} | ||
</div> | ||
<div class="column is-flex foobar" data-test-value-div={{@label}}> | ||
{{#if (has-block)}} | ||
{{yield}} | ||
{{else if this.valueIsBoolean}} | ||
{{#if @value}} | ||
<Icon class="icon-true" @name="check-circle" data-test-boolean-true /> | ||
Yes | ||
{{else}} | ||
<Icon @name="x-square" class="icon-false" data-test-boolean-false /> | ||
No | ||
{{/if}} | ||
{{! alwaysRender is still true }} | ||
{{else if this.valueIsEmpty}} | ||
{{#if @defaultShown}} | ||
<span data-test-row-value={{@label}}>{{@defaultShown}}</span> | ||
{{else}} | ||
<Icon @name="minus" /> | ||
{{/if}} | ||
{{else}} | ||
{{#if (eq @type "array")}} | ||
<InfoTableItemArray | ||
@backend={{@backend}} | ||
@displayArray={{@value}} | ||
@isLink={{@isLink}} | ||
@label={{@label}} | ||
@modelType={{@modelType}} | ||
@queryParam={{@queryParam}} | ||
@viewAll={{@viewAll}} | ||
@wildcardLabel={{@wildcardLabel}} | ||
/> | ||
{{else}} | ||
{{#if @tooltipText}} | ||
<ToolTip @verticalPosition="above" @horizontalPosition="left" as |T|> | ||
<T.Trigger @tabindex={{false}}> | ||
<span class="is-word-break has-text-black" data-test-row-value={{this.label}}>{{this.value}}</span> | ||
</T.Trigger> | ||
<T.Content class="tool-tip"> | ||
<CopyButton | ||
@clipboardText={{@tooltipText}} | ||
@success={{action (set-flash-message "Data copied!")}} | ||
@tagName="div" | ||
@disabled={{not @isTooltipCopyable}} | ||
class={{if @isTooltipCopyable "has-pointer"}} | ||
data-test-tooltip-copy | ||
> | ||
<div class="box"> | ||
{{@tooltipText}} | ||
</div> | ||
</CopyButton> | ||
</T.Content> | ||
</ToolTip> | ||
{{else}} | ||
<span class="is-word-break has-text-black" data-test-row-value={{@label}}>{{@value}}</span> | ||
{{/if}} | ||
{{/if}} | ||
{{/if}} | ||
</div> | ||
</div> | ||
{{/if}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious how that
@data
.... got in there!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably an upgrade maybe even back to the big one in 1.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was the latest ember upgrade. I considered find-replacing all the
@data-test
instances, but we have a few cases where it looks like they're actually supposed to work that way (eg. ToolbarSecretLink 😱)