UI/Hide empty masked PKI row values #14400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellobontempo
commented
Mar 7, 2022
| @@ -75,12 +75,6 @@ | |||
| @label={{capitalize (or attr.options.label (humanize (dasherize attr.name)))}} | |||
| @value={{date-format (get this.model attr.name) "MMM dd, yyyy hh:mm:ss a" isFormatted=true}} | |||
| /> | |||
| {{else if (and (get this.model attr.name) (eq attr.name "revocationTime"))}} | |||
There was a problem hiding this comment.
revocationTime won't exist for a newly generated credential. (I had originally added this before understanding exactly when this template renders)
hellobontempo
commented
Mar 7, 2022
| @@ -45,7 +45,7 @@ | |||
| @label={{capitalize (or attr.options.label (humanize (dasherize attr.name)))}} | |||
| @value={{date-format (get this.model attr.name) "MMM dd, yyyy hh:mm:ss a" isFormatted=true}} | |||
| /> | |||
| {{else if (and (get this.model attr.name) (eq attr.name "revocationTime"))}} | |||
There was a problem hiding this comment.
(get this.model attr.name) returns 0 so this block wasn't being hit and Revocation time: 0 was displaying in the UI. Now zero is passed to the date-format helper which errors so revocation time isn't displayed unless it has a date value
hellobontempo
commented
Mar 10, 2022
| @@ -8,15 +8,15 @@ | |||
| {{/if}} | |||
| </h2> | |||
| {{#if (or this.model.certificate this.model.csr)}} | |||
| {{#if (not (eq this.model.canParse true))}} | |||
| {{#if (eq this.model.canParse false)}} | |||
There was a problem hiding this comment.
canParse is only set when it goes through the parse-pki-cert helper - so we want to check for false specifically, as it could be undefined
hashishaw
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some changes made to the
InfoTableRowcomponent in PR #13585 empty masked values were displaying in the certificate show pages. This PR fixes so only masked inputs with values displayScreeshot of bug
With fix
