Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored support for PHP 5.5 and HHVM 3 #110

Merged
merged 2 commits into from Jun 21, 2020
Merged

Restored support for PHP 5.5 and HHVM 3 #110

merged 2 commits into from Jun 21, 2020

Conversation

GrahamCampbell
Copy link
Member

@GrahamCampbell GrahamCampbell commented Jun 17, 2020

This PR restores support for PHP 5.5 and HHVM 3, to match Guzzle 6.5's supported versions. I have tested against the same version of HHVM that Guzzle 6.5 tests against. After this, I think we are good to tag v1.4.0.

NB The hacks I added in this PR can be undone in v2.0.0, which will certainly drop HHVM and PHP less than 7.2.

@GrahamCampbell GrahamCampbell mentioned this pull request Jun 17, 2020
GrahamCampbell referenced this pull request Jun 17, 2020
hhvm is not even supported by composer anymore and php 5.5 long eol. this way we can also update phpunit.
@Tobion
Copy link
Member

Tobion commented Jun 17, 2020

After this, I think we are good to tag v1.4.0.

I think this should be v1.3.2 as there aren't any real features added since v1.3.1. In v1.4.0 we can then drop support for old php versions.

tests/EachPromiseTest.php Show resolved Hide resolved
@GrahamCampbell
Copy link
Member Author

1.3.2 is fine by me. We just need to change the branch alias from 1.3 to 1.4.

Copy link
Member

@Tobion Tobion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you gonna tag v1.3.2?

@GrahamCampbell
Copy link
Member Author

Before the 1.3.2 release, the change log also needs updating.

@GrahamCampbell
Copy link
Member Author

GrahamCampbell commented Jun 18, 2020

In v1.4.0 we can then drop support for old php versions.

I don't think that's a good idea because:

  1. Version 2.0 probably isn't that far off (maybe September/October with Guzzle 8.0)?
  2. HHVM (non-)support isn't indicated in the composer.json file.
  3. There is no debt in the src directory due to keeping PHP 5.5 and HHVM (especially since HHVM support is only partial), so there is actually no proper motivation to drop the versions (there will be motivation in 2.0, because breaking refactoring can occur and new features from PHP 7.2+ can be used, like scalar types).

@Tobion
Copy link
Member

Tobion commented Jun 18, 2020

What's your plan with v2 of promises? What's the breaking change you plan?

@GrahamCampbell
Copy link
Member Author

GrahamCampbell commented Jun 18, 2020

What's the breaking change you plan?

Adding scalar type hints, and removing the functions file, like in Guzzle, because global functions don't play nice when a different version of the package is installed globally with composer to locally, and leads to bugs like guzzle/guzzle#2511. See guzzle/guzzle#2546. The plan would be to add the new static class methods in 1.4.0 and deprecate the functions, then remove in 2.0.0. Some work already started at #108.

@Tobion Tobion merged commit bbf3b20 into guzzle:master Jun 21, 2020
@GrahamCampbell GrahamCampbell deleted the php-55 branch June 21, 2020 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants