-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.4.0 Release #107
Comments
Hi, Current version get warnings on php 7.4: 222 | WARNING | Function each() is deprecated since PHP 7.2; Use a foreach loop instead |
I think the change that removed PHP 5.5 is a blocker actually. We need to add it back in so that EDIT: Done in #110, and actually the next release will probably be 1.3.2, and not 1.4.0. |
Actually, there is a new feature committed since 1.3.1, so next will be 1.4.0. |
I'll prep a release PR. |
Looks like there are a couple of fixes merged into master that have not yet made it into a release. Looking at the outstanding PRs that could be merged or closed right now, we have:
Looks good to merge to me:
Reject promise instead of throwing if coroutine throws before 1st yield #98Done: mergedAdd explicit object checks before calling method_exists() #105Done: mergedI think should be closed:
Removes unnecessary static access modificator from callHandler #83Done: closedFixed pthreads bug: "The promise was rejected" #91Done: closedNot immediately obvious, risky, or unfinished:
Fix #57 #62Done: closedMake Promise.php shorter and more readable #95Done: mergedThe text was updated successfully, but these errors were encountered: