Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4.0 Release #107

Closed
GrahamCampbell opened this issue Dec 31, 2019 · 4 comments
Closed

1.4.0 Release #107

GrahamCampbell opened this issue Dec 31, 2019 · 4 comments

Comments

@GrahamCampbell
Copy link
Member

GrahamCampbell commented Dec 31, 2019

Looks like there are a couple of fixes merged into master that have not yet made it into a release. Looking at the outstanding PRs that could be merged or closed right now, we have:

Looks good to merge to me:

  1. Reject promise instead of throwing if coroutine throws before 1st yield  #98 Done: merged
  2. Add explicit object checks before calling method_exists() #105 Done: merged

I think should be closed:

  1. Removes unnecessary static access modificator from callHandler #83 Done: closed
  2. Fixed pthreads bug: "The promise was rejected" #91 Done: closed

Not immediately obvious, risky, or unfinished:

  1. Fix #57 #62 Done: closed
  2. Complementary functions with concurrency control #70
  3. Make Promise.php shorter and more readable #95 Done: merged
  4. Param type fix for inspect_all() #104
@p-golovin
Copy link

Hi,
is there any plans on this release?

Current version get warnings on php 7.4:

222 | WARNING | Function each() is deprecated since PHP 7.2; Use a foreach loop instead
257 | WARNING | Function each() is deprecated since PHP 7.2; Use a foreach loop instead
313 | WARNING | Function each() is deprecated since PHP 7.2; Use a foreach loop instead

@GrahamCampbell
Copy link
Member Author

GrahamCampbell commented Jun 17, 2020

I think the change that removed PHP 5.5 is a blocker actually. We need to add it back in so that 1.4.01.3.2 can be included in the next phar release of Guzzle 6.

EDIT: Done in #110, and actually the next release will probably be 1.3.2, and not 1.4.0.

@GrahamCampbell GrahamCampbell changed the title 1.4.0 Release 1.3.2 Release Jun 18, 2020
@GrahamCampbell GrahamCampbell changed the title 1.3.2 Release 1.4.0 Release Jun 27, 2020
@GrahamCampbell
Copy link
Member Author

Actually, there is a new feature committed since 1.3.1, so next will be 1.4.0.

@GrahamCampbell
Copy link
Member Author

I'll prep a release PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants