-
-
Notifications
You must be signed in to change notification settings - Fork 117
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
hhvm is not even supported by composer anymore and php 5.5 long eol. this way we can also update phpunit.
- Loading branch information
Showing
5 changed files
with
15 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,4 @@ | ||
phpunit.xml | ||
composer.phar | ||
composer.lock | ||
composer-test.lock | ||
vendor/ | ||
build/artifacts/ | ||
artifacts/ | ||
docs/_build | ||
docs/*.pyc | ||
.idea | ||
.DS_STORE | ||
vendor/ | ||
composer.lock | ||
phpunit.xml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1db3046
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing PHP 5.5 support was a bad idea because Guzzle 6's phars need to work on PHP 5.5.
1db3046
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is php 5.5 needed in guzzle? You can just releaes a minor version of guzzle that removes php 5.5 support.
1db3046
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restoring PHP 5.5 support is easy. I will send a PR.
1db3046
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to drop it in Guzzle 6. Guzzle 7 will be released next week and drops PHP less than 7.1 entirely. We need to keep Guzzle 6 on PHP 5.5.
1db3046
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guzzle/promises without php 5.5 is not even released yet. Is there a bugfix in promised that guzzle needs? Or what's the reason to restore php 5.5 support?
1db3046
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. There are some bugs affecting PHP 7.2+. The idea is to have 1.4.0 tagged, and rebuild a guzzle phar that works on PHP 5.5 through 7.4 (at some point in the near future).
1db3046
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#110