[7.0] Avoid functions due to global install conflicts #2546
Conversation
GrahamCampbell
changed the title
|
I like this PR. But you have kept the functions. That means there could still be conflicts, right? |
|
I kept them to make sure that upgrading to guzzle 7 is easy. We should deprecate in 7.1.0, and remove in 8.0.0, perhaps? |
|
There will be no conflicts within the internals, at least, so upgrading to Guzzle 7 won't result in Guzzle 7 calling globally installed guzzle 6 functions. |
| use GuzzleHttp\Handler\StreamHandler; | ||
| use Psr\Http\Message\UriInterface; | ||
|
|
||
| final class Utils |
There was a problem hiding this comment.
Please me more defensive here.
Mark it as @internal and write a comment to explain the intent of the class.
There was a problem hiding this comment.
I don't think this class is internal only? We do intend for people to call these class methods, instead of the functions.
There was a problem hiding this comment.
Sure, It is just me that want to get rid of the functions AND eventually this class.
We can discuss that in a separate PR or issue.
Don't call the GuzzleHttp "functions"; instead use class static methods. The functions themselves could be marked as deprecated in 7.1.0.
This is the full version of #2548, which was only applied to the new internal functions added on or after 6.4.0, which are directly causing problems for people.