[6.5] Don't use internal functions #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 12, 2020
phansys
suggested changes
Jan 13, 2020
phansys
reviewed
Jan 13, 2020
Nyholm
approved these changes
Jan 19, 2020
|
Thank you again @GrahamCampbell |
Nyholm
added a commit
that referenced
this pull request
Apr 18, 2020
* Travis improvements * Don't use internal functions (#2548) * [6.5] Install symfony's intl-idn polyfill (#2550) * Install symfony's intl-idn polyfill * idn conversion always available * remove "skipped because of intl" * PHPStan CI fix Co-authored-by: Nyholm <tobias.nyholm@gmail.com> * Prepare release of 6.5.3 (#2613) * Prepare release of 6.5.3 * Typo * Updated date * Updated constant * Fixed composer.json package order Co-authored-by: Márk Sági-Kazár <sagikazarmark@users.noreply.github.com> Co-authored-by: Nyholm <tobias.nyholm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since these functions are internal, this should not be an issue. We maybe could even delete those functions in 7.0.0, outright. A more complete version is available at #2546, targetted at 7.0, since it does the same for the non-internal functions.
Fixes #2511.