Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Adjust unit tests so they work with react 18 #64698

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Chore: Adjust unit tests so they work with react 18 #64698

merged 1 commit into from
Mar 14, 2023

Conversation

ashharrison90
Copy link
Contributor

What is this feature?

  • many unit tests fail when attempting to update to react 18 (see Chore: Upgrade to react 18 #64428)
  • adjusts unit tests so they work with react 18
    • this tackles maybe half of the failing tests
    • a lot of these are moving from fireEvent to userEvent

Why do we need this feature?

  • so we can move to react 18!

Who is this feature for?

  • grafana devs

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

@ashharrison90 ashharrison90 added type/chore no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Mar 13, 2023
@ashharrison90 ashharrison90 added this to the 9.5.0 milestone Mar 13, 2023
@ashharrison90 ashharrison90 self-assigned this Mar 13, 2023
@ashharrison90 ashharrison90 requested review from a team as code owners March 13, 2023 16:32
@ashharrison90 ashharrison90 requested review from bossinc, aangelisc, fridgepoet, iwysiu, axelavargas, polibb, joshhunt and yaelleC and removed request for a team March 13, 2023 16:32
@ashharrison90 ashharrison90 requested a review from mckn March 13, 2023 16:32
@github-actions
Copy link
Contributor

Backend code coverage report for PR #64698
No changes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2023 •
edited

Frontend code coverage report for PR #64698

Plugin Main PR Difference
explore 86.42% 86.42% 0%
loki 83.69% 83.69% 0%

ifrost
ifrost approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@ifrost ifrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explore LGTM 👍

aangelisc
aangelisc approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for Azure 😊

kevinwcyu
kevinwcyu approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@kevinwcyu kevinwcyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for cloudwatch

matyax
matyax reviewed Mar 14, 2023
View reviewed changes
Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loki part looks good! 👍

@ashharrison90 ashharrison90 merged commit 85e5326 into main Mar 14, 2023
@ashharrison90 ashharrison90 deleted the ash/react-18-test-updates branch March 14, 2023 17:24
This was referenced Mar 14, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyax matyax matyax left review comments

@ifrost ifrost ifrost approved these changes

@aangelisc aangelisc aangelisc approved these changes

@kevinwcyu kevinwcyu kevinwcyu approved these changes

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@fridgepoet fridgepoet Awaiting requested review from fridgepoet fridgepoet is a code owner automatically assigned from grafana/aws-datasources

@iwysiu iwysiu Awaiting requested review from iwysiu iwysiu is a code owner automatically assigned from grafana/aws-datasources

@axelavargas axelavargas Awaiting requested review from axelavargas axelavargas is a code owner automatically assigned from grafana/dashboards-squad

@polibb polibb Awaiting requested review from polibb polibb is a code owner automatically assigned from grafana/dashboards-squad

@joshhunt joshhunt Awaiting requested review from joshhunt joshhunt is a code owner automatically assigned from grafana/grafana-frontend-platform

@yaelleC yaelleC Awaiting requested review from yaelleC yaelleC is a code owner automatically assigned from grafana/grafana-frontend-platform

@mckn mckn Awaiting requested review from mckn mckn was automatically assigned from grafana/plugins-platform-frontend

Assignees

@ashharrison90 ashharrison90

Labels
area/explore area/frontend datasource/Azure Azure Monitor Datasource datasource/CloudWatch datasource/Loki datasource/Prometheus no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/chore
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ashharrison90 @ifrost @matyax @aangelisc @kevinwcyu @grafanabot