Chore: update more unit tests to work with react 18 #64812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashharrison90
added
type/chore
no-backport
ashharrison90
requested review from
asimpson,
aangelisc,
leventebalogh,
joshhunt and
tskarhed
and removed request for
a team
grafanabot
added
datasource/Tempo
area/explore
area/frontend
datasource/Azure
|
Backend code coverage report for PR #64812 |
|
Frontend code coverage report for PR #64812
|
leventebalogh
approved these changes
Mar 16, 2023
| expect(screen.queryByText('Loading...')).not.toBeInTheDocument(); | ||
| const selection = await screen.findAllByLabelText('web-server'); |
There was a problem hiding this comment.
Question: do we still need to wait here for the web-server label?
There was a problem hiding this comment.
yes - in react 18 the selection comes back with a length of 1 initially. subsequent rerenders change this to 2, but if it's not in a waitFor the test will have already failed 😓
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
fireEventtouserEventWhy do we need this feature?
Who is this feature for?
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
follow on from #64698 and #64759