Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: adjust more unit tests to work with react 18 #64759

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Chore: adjust more unit tests to work with react 18 #64759

merged 1 commit into from
Mar 15, 2023

Conversation

ashharrison90
Copy link
Contributor

What is this feature?

  • many unit tests fail when attempting to update to react 18 (see Chore: Upgrade to react 18 #64428)
  • adjusts unit tests so they work with react 18
    • a lot of these are moving from fireEvent to userEvent

Why do we need this feature?

  • so we can move to react 18!

Who is this feature for?

  • grafana devs

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

follow on from #64698

@ashharrison90 ashharrison90 added type/chore no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Mar 14, 2023
@ashharrison90 ashharrison90 added this to the 9.5.0 milestone Mar 14, 2023
@ashharrison90 ashharrison90 self-assigned this Mar 14, 2023
@ashharrison90 ashharrison90 requested review from a team and joshhunt as code owners March 14, 2023 17:26
@ashharrison90 ashharrison90 requested a review from a team March 14, 2023 17:26
@ashharrison90 ashharrison90 requested a review from a team as a code owner March 14, 2023 17:26
@ashharrison90 ashharrison90 requested review from asimpson, aangelisc, idastambuk, kevinwcyu, dprokop, ivanortegaalba and andresmgot and removed request for a team March 14, 2023 17:26
@ashharrison90 ashharrison90 requested review from tskarhed, oscarkilhed and mdvictor and removed request for a team March 14, 2023 17:26
aangelisc
aangelisc approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure looks good! Cloud monitoring also looks good, just not sure if the change to the VisualMetricQueryEditor will throw an act error or not 😊

@github-actions
Copy link
Contributor

Backend code coverage report for PR #64759
No changes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2023 •
edited

Frontend code coverage report for PR #64759

Plugin Main PR Difference
correlations 87.23% 87.23% 0%
explore 86.42% 86.42% 0%
loki 83.69% 83.69% 0%

matyax
matyax reviewed Mar 15, 2023
View reviewed changes
Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loki part looks good! 👍

itsmylife
itsmylife approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@itsmylife itsmylife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prometheus lgtm

@ashharrison90 ashharrison90 merged commit e0e6165 into main Mar 15, 2023
@ashharrison90 ashharrison90 deleted the ash/react-18-unit-tests-p2 branch March 15, 2023 10:12
@ashharrison90 ashharrison90 mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyax matyax matyax left review comments

@itsmylife itsmylife itsmylife approved these changes

@aangelisc aangelisc aangelisc approved these changes

@joshhunt joshhunt Awaiting requested review from joshhunt

@asimpson asimpson Awaiting requested review from asimpson asimpson is a code owner automatically assigned from grafana/partner-datasources

@idastambuk idastambuk Awaiting requested review from idastambuk idastambuk is a code owner automatically assigned from grafana/aws-datasources

@kevinwcyu kevinwcyu Awaiting requested review from kevinwcyu kevinwcyu is a code owner automatically assigned from grafana/aws-datasources

@dprokop dprokop Awaiting requested review from dprokop dprokop is a code owner automatically assigned from grafana/dashboards-squad

@ivanortegaalba ivanortegaalba Awaiting requested review from ivanortegaalba ivanortegaalba is a code owner automatically assigned from grafana/dashboards-squad

@andresmgot andresmgot Awaiting requested review from andresmgot andresmgot is a code owner automatically assigned from grafana/plugins-platform-frontend

@tskarhed tskarhed Awaiting requested review from tskarhed tskarhed is a code owner automatically assigned from grafana/grafana-frontend-platform

@oscarkilhed oscarkilhed Awaiting requested review from oscarkilhed

@mdvictor mdvictor Awaiting requested review from mdvictor

Assignees

@ashharrison90 ashharrison90

Labels
area/explore area/frontend datasource/Azure Azure Monitor Datasource datasource/CloudWatch datasource/GoogleCloudMonitoring datasource/Loki datasource/Prometheus no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/chore
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ashharrison90 @itsmylife @matyax @aangelisc @grafanabot