(#7323) Rename CMake files according to project name #7378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename FlatbuffersConfigVersion.cmake to match CMake project name
Rename FlatBuffersTargets to match CMake project name
|
Thanks! |
sssooonnnggg
pushed a commit
to sssooonnnggg/flatbuffers
that referenced
this pull request
Aug 8, 2022
* CMake find_package fixes (google#7323) Rename FlatbuffersConfigVersion.cmake to match CMake project name * CMake find_package fixes (google#7323) Rename FlatBuffersTargets to match CMake project name
yan12125
pushed a commit
to archlinuxcn/repo
that referenced
this pull request
Aug 27, 2022
Upstream flatbuffers renamed the package from Flatbuffers to FlatBuffers (capital B) [1]. Fixes the issue reported at https://aur.archlinux.org/packages/python-onnxruntime#comment-879320 Also drops patches that are part of the latest version. [1] google/flatbuffers#7378
archlinux-github
pushed a commit
to archlinux/aur
that referenced
this pull request
Aug 27, 2022
Upstream flatbuffers renamed the package from Flatbuffers to FlatBuffers (capital B) [1]. Fixes the issue reported at https://aur.archlinux.org/packages/python-onnxruntime#comment-879320 Also drops patches that are part of the latest version. [1] google/flatbuffers#7378
|
It's a breaking change (as you can see in linked commit of archlinux), |
|
@SpaceIm you are right. This slipped me. I will open an issue and propose a PR to fix it right away. |
|
Created #7502 to address this issue. Sorry for any inconvenience caused. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses (#7323).
CMake installation output is attached. The files are renamed and the targets are working.
installation.txt