Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] find_package(Flatbuffers CONFIG) not working due to breaking change #7499

Closed
clanghans opened this issue Aug 31, 2022 · 2 comments
Closed

[CMake] find_package(Flatbuffers CONFIG) not working due to breaking change #7499

clanghans opened this issue Aug 31, 2022 · 2 comments

Comments

@clanghans
Copy link
Contributor

(#7378) introduces a breaking change because

find_package(Flatbuffers CONFIG)

will not work anymore.
@clanghans clanghans mentioned this issue Aug 31, 2022
Closed
clanghans added a commit to clanghans/flatbuffers that referenced this issue Aug 31, 2022
@clanghans
[CMake]: fix breaking find_package change (google#7499)
0b2f7e2
@clanghans clanghans mentioned this issue Aug 31, 2022
Merged
@clanghans
Copy link
Contributor Author

Created #7502 to address this issue.

Sorry for any inconvenience caused.

dbaileychess pushed a commit to clanghans/flatbuffers that referenced this issue Aug 31, 2022
@clanghans @dbaileychess
[CMake]: fix breaking find_package change (google#7499)
c3ee359
dbaileychess added a commit that referenced this issue Sep 1, 2022
@clanghans @dbaileychess
[CMake]: fix breaking find_package change (#7499) (#7502)
d465b39 
Co-authored-by: Derek Bailey <derekbailey@google.com>
@Algram
Copy link

Algram commented Sep 2, 2022 •
edited

Thanks for fixing this! Is there an ETA on when we are getting a new release with this fix? I am a maintainer for the nixpkgs repo and trying to decide whether it is worth patching this on our end or just waiting for the new upstream release.

This was referenced Sep 10, 2022
Closed
Closed
Algram added a commit to Algram/nixpkgs that referenced this issue Sep 10, 2022
@Algram
flatbuffers: 2.0.7 -> unstable-2022-09-11
5379109 
New version with fix for the cmake integration has not yet been released: google/flatbuffers#7499.
@JulZimmermann JulZimmermann mentioned this issue Sep 21, 2022
Closed
yan12125 pushed a commit to archlinuxcn/repo that referenced this issue Sep 29, 2022
python-tf2onnx: unpin flatbuffers and update deps
50f2fe1 
See: google/flatbuffers#7499
archlinux-github pushed a commit to archlinux/aur that referenced this issue Sep 29, 2022
unpin flatbuffers and update deps
411f407 
See: google/flatbuffers#7499
archlinux-github pushed a commit to archlinux/aur that referenced this issue Oct 25, 2022
@yan12125
python-onnxruntime: split C++ and Python libraries & some other changes
58086ca 
* Rename python-onnxruntime-cuda to onnxruntime-cuda - this split
  package actually does not contain Python libraries.
* Move optdepends to the correct package
* Drop flatbuffers fix after upstream adds the compatibility back [1]
* Improve onednn patch - fallback to bundled onednn if the system one
  is missing & wrap other usage of `DNNL_DLL_PATH`
* Add CUDA architectures introduced in CUDA 11.8. See [2]
* Refresh patches for 1.13

[1] google/flatbuffers#7499
[2] archlinux/svntogit-community@54642de
yan12125 pushed a commit to archlinuxcn/repo that referenced this issue Oct 25, 2022
@yan12125
python-onnxruntime: split C++ and Python libraries & some other changes
c3dd234 
* Rename python-onnxruntime-cuda to onnxruntime-cuda - this split
  package actually does not contain Python libraries.
* Move optdepends to the correct package
* Drop flatbuffers fix after upstream adds the compatibility back [1]
* Improve onednn patch - fallback to bundled onednn if the system one
  is missing & wrap other usage of `DNNL_DLL_PATH`
* Add CUDA architectures introduced in CUDA 11.8. See [2]
* Refresh patches for 1.13

[1] google/flatbuffers#7499
[2] archlinux/svntogit-community@54642de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Algram @clanghans