[flatbuffers] update to 2.0.8 #13247
Conversation
recipes/flatbuffers/all/conanfile.py
Outdated
| if Version(self.version) < "2.0.7": | ||
| self.cpp_info.set_property("cmake_file_name", "Flatbuffers") | ||
| else: | ||
| self.cpp_info.set_property("cmake_file_name", "FlatBuffers") |
There was a problem hiding this comment.
There was a problem hiding this comment.
prefer google/flatbuffers#7502, and use this value unconditionally since it allows case insensitive find_package()
There was a problem hiding this comment.
I changed it in d4c03f3.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| def build_requirements(self): | ||
| if Version(self.version) >= "2.0.7": | ||
| self.tool_requires("cmake/3.24.0") |
There was a problem hiding this comment.
CMake 3.16 is now the minimum supported version number. They have a legacy CMakeLists.txt for older CMake versions which is unmaintained, however, and does not work.
|
All green in build 4 (
|
|
@chausner what is missing to be ready for review? |
Thanks for the reminder, forgot to mark as ready. |
* Update flatbuffers to 2.0.8 * Fix version variables * Change CMake file names to lowercase * Add CMake build requirement Co-authored-by: chausner <chausner@users.noreply.github.com>
Specify library name and version: flatbuffers/2.0.8
This updates flatbuffers to the latest version 2.0.8.