[gl] replace Surfman by EGL #3470
Conversation
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
There was a problem hiding this comment.
This looks great, thank you!
I think this is a good direction 👍 I think we can probably use a similar path for WebGL by creating contexts ahead of time and later reusing them.
Only supporting OpenGL ES sounds fine for now, we can always look into the issues with desktop OpenGL later if it's needed by anyone.
bors r+
3470: [gl] replace Surfman by EGL r=grovesNL a=kvark Fixes #3468 This is a BIG change. It re-architects WSI of the GL backend to unconditionally use EGL (via `khronos-egl` crate atm, but we can change that). This means the backend is *only* supported on Linux/BSD/Android, it's no longer supported on Apple and Microsoft platforms. One of the consequences - we throw Surfman away. There was too much complication and too little benefit from it anyway. Another consequence - we are locked to GLES, given that I experienced issues trying to get a desktop GL context via EGL. We can revisit this, but really I think going with GLES 3.1 makes total sense for the backend, unconditionally. if the target platform is powerful above what GLES 3.1 offers, it should just support Vulkan. Most importantly, it solves GL context sharing, so presentation is much more robust. However, it doesn't solve the extra copy - #3469. For this, we'll need to follow-up by directly using platform extensions, such as [EGL_WL_create_wayland_buffer_from_image](https://www.khronos.org/registry/EGL/extensions/WL/EGL_WL_create_wayland_buffer_from_image.txt). PR checklist: - [x] `make` succeeds (on *nix) - [x] `make reftests` succeeds - [x] tested examples with the following backends: Linux Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com>
|
Build failed: |
|
Oh I didn't notice the CI failures, we need to add the egl package on Linux and disable gl on macOS. I'm not sure about the Android failure but maybe we could disable CI on gl there temporarily:
https://github.com/gfx-rs/gfx/pull/3470/checks?check_run_id=1372587404#step:5:83 |
|
Filed timothee-haudebourg/khronos-egl#6, will disable Android here for now |
It would be very useful here to retrieve WebGL support. I have no dev background in neither WebGL nor OpenGL, but I may help somehow. |
|
We are definitely going to keep WebGL support, although I haven't tested it in a while. You can try following the instructions in ccf789d on master to see where we stand now? I hope it's not broken, or otherwise it should have been caught by CI. |
|
gfx-backend-gl doesn’t build with wasm32-unknown-unknown target since |
|
Ah ok. So you can definitely help by fixing this and re-enabling the WASM build on CI! |
3475: re-enable WebGL support r=grovesNL a=MarcAntoine-Arnaud Mentionned in #3470 Maybe help issue #2749 PR checklist: - [x] re-enable WebGL rendering - [x] use published version of `spirv_cross` dependency - [x] re-enable CI - [x] check and update examples Co-authored-by: Marc-Antoine Arnaud <maarnaud@media-io.com>
Fixes #3468
This is a BIG change. It re-architects WSI of the GL backend to unconditionally use EGL (via
khronos-eglcrate atm, but we can change that). This means the backend is only supported on Linux/BSD/Android, it's no longer supported on Apple and Microsoft platforms.One of the consequences - we throw Surfman away. There was too much complication and too little benefit from it anyway.
Another consequence - we are locked to GLES, given that I experienced issues trying to get a desktop GL context via EGL. We can revisit this, but really I think going with GLES 3.1 makes total sense for the backend, unconditionally. if the target platform is powerful above what GLES 3.1 offers, it should just support Vulkan.
Most importantly, it solves GL context sharing, so presentation is much more robust. However, it doesn't solve the extra copy - #3469. For this, we'll need to follow-up by directly using platform extensions, such as EGL_WL_create_wayland_buffer_from_image.
PR checklist:
makesucceeds (on *nix)make reftestssucceeds