Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable WebGL support #3475

Merged
merged 1 commit into from
Nov 21, 2020
Merged

re-enable WebGL support #3475

merged 1 commit into from
Nov 21, 2020

Conversation

MarcAntoine-Arnaud
Copy link
Contributor

@MarcAntoine-Arnaud MarcAntoine-Arnaud commented Nov 14, 2020 •
edited

Mentionned in #3470
Maybe help issue #2749

PR checklist:

  • re-enable WebGL rendering
  • use published version of spirv_cross dependency
  • re-enable CI
  • check and update examples

kvark
kvark reviewed Nov 14, 2020
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
examples/Cargo.toml Outdated Show resolved Hide resolved
examples/quad/Cargo.toml Outdated Show resolved Hide resolved
src/backend/metal/Cargo.toml Outdated Show resolved Hide resolved
@kvark kvark requested a review from grovesNL November 14, 2020 15:51
@MarcAntoine-Arnaud MarcAntoine-Arnaud mentioned this pull request Nov 15, 2020
Open
grovesNL
grovesNL reviewed Nov 15, 2020
View reviewed changes
examples/quad/Cargo.toml Outdated Show resolved Hide resolved
examples/quad/README.md Outdated Show resolved Hide resolved
examples/quad/data/spirv_cross_wrapper_glsl.js Outdated Show resolved Hide resolved
src/backend/metal/Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
examples/quad/src/main.rs Outdated Show resolved Hide resolved
examples/quad/package.json Outdated Show resolved Hide resolved
examples/quad/webpack.config.js Outdated Show resolved Hide resolved
grovesNL
grovesNL approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! Could you please squash all commits before we merge this?

@grovesNL
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 21, 2020

Build succeeded:

@bors bors bot merged commit d168c0c into gfx-rs:master Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark left review comments

@grovesNL grovesNL grovesNL approved these changes

@monocodus monocodus[bot] monocodus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarcAntoine-Arnaud @grovesNL @kvark