New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade k8s.io/*
to v0.25
, sigs.k8s.io/controller-runtime
to v0.13
#6668
Conversation
ad6e673
to
98861d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR, well-structured, easily reviewable. Well done :)
/approve
Waiting for feedback of @acumino
a232723
to
d3b2441
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can adapt similar changes here
gardener/pkg/seedadmissioncontroller/webhooks/admission/extensionresources/admission.go
Line 64 in 7f0e399
if err := builder.WebhookManagedBy(mgr).WithValidator(validator).For(obj).Complete(); err != nil { |
Failure is not related to this PR. Opened #6671 |
db10cf5
to
c9fc180
Compare
@shafeeqes: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acumino, rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area open-source
/kind enhancement
What this PR does / why we need it:
Upgrade dependencies
Which issue(s) this PR fixes:
Fixes #6661
Special notes for your reviewer:
Release note: