Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

☂️-Issue for "Support for Kubernetes v1.25” #6567

Closed
25 tasks done
rfranzke opened this issue Aug 24, 2022 · 14 comments
Closed
25 tasks done

☂️-Issue for "Support for Kubernetes v1.25” #6567

rfranzke opened this issue Aug 24, 2022 · 14 comments
Assignees
@shafeeqes
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority) topology/garden Affects Garden clusters topology/seed Affects Seed clusters topology/shoot Affects Shoot clusters

Comments

@rfranzke
Copy link
Member

rfranzke commented Aug 24, 2022 •
edited by shafeeqes

/area open-source
/kind enhancement
/priority 3
/topology garden seed shoot

Kubernetes v1.25 has been released, find the changelog here: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.25.md

Work can be started and pushed to the kubernetes-v1.25 branch. There should be similar branches in the provider extension repositories in case the work has been started already.

Note: Seeds do not support v1.25 yet (Tracked separately in #6893 ) because of:

Tasks

Hyperkube

Gardener

Cloud Controller Managers

  • cloud-provider-aws
    • Maintain legacy-cloud-providers and create release-v1.25 branch from it (update container images and revendor latest Kubernetes patch): v1.25.2
    • Maintain release-v1.24 branch (update container images and revendor latest Kubernetes patch): v1.24.6
    • Maintain release-v1.23 branch (update container images and revendor latest Kubernetes patch): v1.23.12
    • Maintain release-v1.22 branch (update container images and revendor latest Kubernetes patch): v1.22.15
  • cloud-provider-azure
    • Maintain release-v1.22 branch (update container images and revendor latest Kubernetes patch): v1.22.15
  • cloud-provider-gcp
    • Maintain legacy-cloud-providers and create release-v1.25 branch from it (update container images and revendor latest Kubernetes patch): v1.25.2
    • Maintain release-v1.24 branch (update container images and revendor latest Kubernetes patch): v1.24.6
    • Maintain release-v1.23 branch (update container images and revendor latest Kubernetes patch): v1.23.12
    • Maintain release-v1.22 branch (update container images and revendor latest Kubernetes patch): v1.22.15

Provider Extensions

Networking Extensions

Machine Controller Manager

Shoot Extensions
@gardener-prow gardener-prow bot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority) labels Aug 24, 2022
@shafeeqes
Copy link
Contributor

/assign

@shafeeqes shafeeqes mentioned this issue Aug 24, 2022
Closed
6 tasks
@ialidzhikov
Copy link
Member

Maintain legacy-cloud-providers and create release-v1.25 branch from it (update container images and revendor latest Kubernetes patch):

With 1.25 the folks (@dkistner and @kon-angelo) wanted to try out the upstream CCM - ref gardener/gardener-extension-provider-aws#577.

@rfranzke
Copy link
Member Author

@dkistner @kon-angelo Can this switch to the OOT CCM also be done later (after 1.25 is already supported) so that we get rid this dependency on the tasks?

@shafeeqes shafeeqes added topology/garden Affects Garden clusters topology/shoot Affects Shoot clusters topology/seed Affects Seed clusters labels Aug 24, 2022
@kon-angelo
Copy link
Contributor

kon-angelo commented Aug 24, 2022 •
edited

The argument in the past was to not perform the upgrade in the middle of kubernetes releases so that we don't have any weird or unexpected behaviour due to the transition.

In general OOT should be a superset of the behavior of the in-tree CCM. In practice if we go though with upgrade in-tree now, we would need to verify one extra transition (in-tree 1.25 -> oot 1.25) in addition to the others, but I do not think it would be that much extra effort.

@rfranzke
Copy link
Member Author

OK, cc @shafeeqes. Let's see how it goes then and talk about this once we have finished the other items from above list.

This was referenced Sep 1, 2022
Merged
Merged
Merged
Merged
Merged
Merged
@ialidzhikov
Copy link
Member

With 1.25 the folks (@dkistner and @kon-angelo) wanted to try out the upstream CCM - ref gardener/gardener-extension-provider-aws#577.

I was actually thinking about this topic and I guess it will be best if you @dkistner and @kon-angelo can handle this with a feature gate so we can decouple it from the 1.25 topic. At the end, our final goal is a controlled rollout and a feature gate should do the trick. WDYT?

@kon-angelo
Copy link
Contributor

@ialidzhikov I think that is a great idea. If my previous comment was not clear as to its intentions, I agree that we can and should decouple it from gardener's 1.25 support and doing it via feature gate could be a good way to introduce the change.

This was referenced Sep 5, 2022
Merged
Merged
Merged
Merged
@dimityrmirchev dimityrmirchev mentioned this issue Sep 13, 2022
Merged
This was referenced Sep 14, 2022
Merged
Merged
Merged
Merged
@shafeeqes shafeeqes mentioned this issue Sep 15, 2022
Merged
This was referenced Sep 26, 2022
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 3, 2022
Merged
Merged
Merged
Merged
Merged
@ashwani2k ashwani2k mentioned this issue Oct 7, 2022
Closed
3 tasks
@shafeeqes
Copy link
Contributor

/close
All tasks are completed.

@gardener-prow gardener-prow bot closed this as completed Oct 21, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 21, 2022

@shafeeqes: Closing this issue.

In response to this:

/close
All tasks are completed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ialidzhikov
Copy link
Member

Shouldn't we keep it open for

Please note that Gardener does not support 1.25 seeds yet.

?

Ref https://github.com/gardener/gardener/blob/v1.57.1/docs/usage/supported_k8s_versions.md#seed-cluster-versions

Or is it tracked somewhere else?

@shafeeqes shafeeqes mentioned this issue Oct 25, 2022
Closed
5 tasks
@shafeeqes
Copy link
Contributor

Shouldn't we keep it open for

Please note that Gardener does not support 1.25 seeds yet.

?

Ref https://github.com/gardener/gardener/blob/v1.57.1/docs/usage/supported_k8s_versions.md#seed-cluster-versions

Or is it tracked somewhere else?

Opened a new issue. We can keep this closed.

@shafeeqes shafeeqes mentioned this issue Nov 11, 2022
Merged
@shafeeqes shafeeqes mentioned this issue Dec 9, 2022
Merged
@shafeeqes
Copy link
Contributor

We need to use cluster autoscaler v1.25 for 1.25 Shoots,
Current version has logs,

W1214 13:53:18.709613       1 reflector.go:324] k8s.io/autoscaler/cluster-autoscaler/utils/kubernetes/listers.go:309: failed to list *v1beta1.PodDisruptionBudget: the server could not find the requested resource
E1214 13:53:18.709636       1 reflector.go:138] k8s.io/autoscaler/cluster-autoscaler/utils/kubernetes/listers.go:309: Failed to watch *v1beta1.PodDisruptionBudget: failed to list *v1beta1.PodDisruptionBudget: the server could not find the requested resource

/assign @himanshu-kun @rishabh-11

@shafeeqes shafeeqes reopened this Dec 14, 2022
@rishabh-11 rishabh-11 mentioned this issue Dec 15, 2022
Merged
@shafeeqes
Copy link
Contributor

/close
#7209 is merged.

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Dec 15, 2022

@shafeeqes: Closing this issue.

In response to this:

/close
#7209 is merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gardener-prow gardener-prow bot closed this as completed Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shafeeqes shafeeqes

Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority) topology/garden Affects Garden clusters topology/seed Affects Seed clusters topology/shoot Affects Shoot clusters
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ialidzhikov @rfranzke @shafeeqes @rishabh-11 @kon-angelo @himanshu-kun