Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Kubernetes v1.25 #6638

Merged
merged 19 commits into from
Sep 13, 2022
Merged

Support for Kubernetes v1.25 #6638

merged 19 commits into from
Sep 13, 2022

Conversation

shafeeqes
Copy link
Contributor

@shafeeqes shafeeqes commented Sep 7, 2022

How to categorize this PR?

/area open-source usability
/kind enhancement
/topology garden seed shoot

What this PR does / why we need it:
Support for Kubernetes v1.25

Which issue(s) this PR fixes:
Part of #6567

Special notes for your reviewer:

Release note:

Gardener can now support shoot clusters with Kubernetes version 1.25. In order to allow creation/update of 1.25 clusters you will have to update the version of your provider extension(s) to a version that supports 1.25 as well. Please consult the respective releases and notes in the provider extension's repository.
Gardener can now support shoot clusters with Kubernetes version 1.25. Extension developers have to prepare individual extensions as well to work with 1.25.

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Sep 7, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Sep 7, 2022
@gardener-prow gardener-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 7, 2022
@rfranzke
Copy link
Member

rfranzke commented Sep 7, 2022

/assign

@shafeeqes shafeeqes force-pushed the kubernetes-v1.25 branch 4 times, most recently from 7b7bb3b to 7126b6f Compare September 7, 2022 10:38
@shafeeqes shafeeqes force-pushed the kubernetes-v1.25 branch 4 times, most recently from 7a11478 to 1fb0c52 Compare September 8, 2022 08:48
@gardener-prow gardener-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 9, 2022
@shafeeqes shafeeqes marked this pull request as ready for review September 9, 2022 06:04
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2022
@shafeeqes shafeeqes force-pushed the kubernetes-v1.25 branch 3 times, most recently from 6406b72 to 9f1440a Compare September 9, 2022 09:47
@rfranzke
Copy link
Member

Thanks @shafeeqes, this looks good now. Let's go
/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Sep 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2022
@shafeeqes
Copy link
Contributor Author

/test pull-gardener-check-vulnerabilities

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Sep 13, 2022

@shafeeqes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-check-vulnerabilities af2bd99 link false /test pull-gardener-check-vulnerabilities

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shafeeqes
Copy link
Contributor Author

@shafeeqes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-check-vulnerabilities af2bd99 link false /test pull-gardener-check-vulnerabilities
Full PR test history. Your PR dashboard. Command help for this repository. Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

This passed yesterday 👀

Call stacks in your code:
      cmd/gardener-seed-admission-controller/app/gardener_seed_admission_controller.go:[19](https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/6638/pull-gardener-check-vulnerabilities/1569528608265867264#1:build-log.txt%3A19)0:18: github.com/gardener/gardener/cmd/gardener-seed-admission-controller/app.Options.Run calls sigs.k8s.io/controller-runtime/pkg/manager.controllerManager.Start, which eventually calls golang.org/x/net/http2.ConfigureServer$1
  Found in: golang.org/x/net/http2@v0.0.0-[20](https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/6638/pull-gardener-check-vulnerabilities/1569528608265867264#1:build-log.txt%3A20)22072[21](https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/6638/pull-gardener-check-vulnerabilities/1569528608265867264#1:build-log.txt%3A21)55237-a158d28d115b
  Fixed in: golang.org/x/net/http2@v1.19.1

@rfranzke
Copy link
Member

That's why the check optional - vulnerabilities can pop up at any point in time. This one should be unrelated to changes of this PR.

@shafeeqes
Copy link
Contributor Author

shafeeqes commented Sep 13, 2022

This one should be unrelated to changes of this PR.

Yep.

@gardener-prow gardener-prow bot merged commit 85a13f1 into master Sep 13, 2022
@gardener-prow gardener-prow bot deleted the kubernetes-v1.25 branch September 13, 2022 04:12
@vlerenc
Copy link
Member

vlerenc commented Oct 4, 2022

We have now a tool that checks for DISA STIG K8s compliance. We have only trivial/cosmetic findings that can possibly be changed at any time, but these two may have end user tangible consequences, so it would be good to combine them with a new Kubernetes minor version or we need to wait another 4 months for the next one. WDYT @shafeeqes @rfranzke?

Both should be very quick and simple to fix, but will this possibly alter behaviour (242434 for the workload and 245541 when interacting with the Kubelet via the API server like streaming logs, etc.)?

If so (or unclear), we should probably better combine this with a new Kubernetes minor version (e.g. this one here, v1.25)?

@rfranzke
Copy link
Member

rfranzke commented Oct 4, 2022

I think we have to wait for 1.26, this PR is already merged since 3 weeks and released as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants