Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only run golint on latest version of go #284

Merged
merged 3 commits into from Mar 8, 2019

Conversation

cpuguy83
Copy link
Contributor

@cpuguy83 cpuguy83 commented Mar 4, 2019

What does this pull request do?

  • Changes travis config to only run golint on latest go version
  • Adds 1.11 and 1.12 to to the go version list to test against

Where should the reviewer start?

Does CI pass?
Does golint run on go1.12?

How should this be manually tested?

N/A

Fixes #275
Closes #271

@cpuguy83 cpuguy83 force-pushed the fix_linters branch 8 times, most recently from de1bbf2 to 1b229aa Compare March 8, 2019 03:51
- go get -u golang.org/x/lint/golint

before_install:
- if [ ! -z "${GOLINT}" ]; then go get -u golang.org/x/lint/golint; fi

script:
- go test --race ./...

after_script:
- test -z "$(gofmt -s -l -w . | tee /dev/stderr)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks Brian!

It does make me wonder if we need to run gofmt or go vet on anything but the stable release too, but for now it doesn't hurt.

@nathany
Copy link
Contributor

nathany commented Mar 8, 2019

Thanks @cpuguy83. Two questions:

  • Have you signed the Google CLA at some point in the past? We're still using that for now. review license and CLA #119
  • Is there a related issue with regards to golint not working with older versions of Go? (just to document one of the reasons for this change)

@nathany
Copy link
Contributor

nathany commented Mar 8, 2019

I've removed AppVeyor. This is the appveyor.yml export in case we ever need to bring it back. I will remove the badge shortly.

version: 1.0.{build}
clone_folder: C:\GOPATH\src
environment:
  GOPATH: C:\GOPATH
build_script:
- cmd: >-
    go version

    go get -v -d -t github.com/fsnotify/fsnotify
test_script:
- cmd: go test -v --race -cover ./...

@nathany nathany merged commit 85de84f into fsnotify:master Mar 8, 2019
@cpuguy83 cpuguy83 deleted the fix_linters branch March 8, 2019 17:05
@cpuguy83
Copy link
Contributor Author

cpuguy83 commented Mar 8, 2019

Yes, I've signed the Google CLA, FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants