New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only run golint on latest version of go #284
Conversation
de1bbf2
to
1b229aa
Compare
- go get -u golang.org/x/lint/golint | ||
|
||
before_install: | ||
- if [ ! -z "${GOLINT}" ]; then go get -u golang.org/x/lint/golint; fi | ||
|
||
script: | ||
- go test --race ./... | ||
|
||
after_script: | ||
- test -z "$(gofmt -s -l -w . | tee /dev/stderr)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks Brian!
It does make me wonder if we need to run gofmt
or go vet
on anything but the stable release too, but for now it doesn't hurt.
Thanks @cpuguy83. Two questions:
|
I've removed AppVeyor. This is the appveyor.yml export in case we ever need to bring it back. I will remove the badge shortly.
|
Yes, I've signed the Google CLA, FYI. |
What does this pull request do?
Where should the reviewer start?
Does CI pass?
Does golint run on go1.12?
How should this be manually tested?
N/A
Fixes #275
Closes #271