Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only run golint on latest version of go #284

Merged
merged 3 commits into from Mar 8, 2019
Merged

only run golint on latest version of go #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c984ca
only run golint on latest version of go
cpuguy83 Mar 4, 2019
f1d4748
Fix lint issue with error doc string
cpuguy83 Mar 8, 2019
7141d0e
Add windows to travis matrix
cpuguy83 Mar 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 10 additions & 4 deletions .travis.yml
View file
Open in desktop
Expand Up @@ -3,29 +3,35 @@ language: go

go:
- "stable"
- "1.10.4"
- "1.11.x"
- "1.10.x"
- "1.9.x"
- "1.8.x"

matrix:
include:
- go: "stable"
env: GOLINT=true
allow_failures:
- go: tip
fast_finish: true

before_script:
- go get -u golang.org/x/lint/golint

before_install:
- if [ ! -z "${GOLINT}" ]; then go get -u golang.org/x/lint/golint; fi

script:
- go test --race ./...

after_script:
- test -z "$(gofmt -s -l -w . | tee /dev/stderr)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks Brian!

It does make me wonder if we need to run gofmt or go vet on anything but the stable release too, but for now it doesn't hurt.

- test -z "$(golint ./... | tee /dev/stderr)"
- if [ ! -z "${GOLINT}" ]; then echo running golint; golint --set_exit_status ./...; else echo skipping golint; fi
- go vet ./...

os:
- linux
- osx
- windows

notifications:
email: false
4 changes: 3 additions & 1 deletion fsnotify.go
View file
Open in desktop
Expand Up @@ -63,4 +63,6 @@ func (e Event) String() string {
}

// Common errors that can be reported by a watcher
var ErrEventOverflow = errors.New("fsnotify queue overflow")
var (
ErrEventOverflow = errors.New("fsnotify queue overflow")
)