fix ErrEventOverflow as per golint warning.
#247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhooyr
suggested changes
May 25, 2018
| @@ -62,5 +62,5 @@ func (e Event) String() string { | |||
| return fmt.Sprintf("%q: %s", e.Name, e.Op.String()) | |||
| } | |||
|
|
|||
| // Common errors that can be reported by a watcher | |||
There was a problem hiding this comment.
I believe this comment is meant for multiple errors. Could you change the comment to ErrEventOverflow can be reported by a watcher.
nhooyr
approved these changes
May 25, 2018
|
Ah, sorry I fixed this as part of #284 (golint would not even run on CI for go1.8). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Simple comment text update. Fixes
golintwarning: https://goreportcard.com/report/github.com/fsnotify/fsnotify#golintWhere should the reviewer start?
Install and run
golintHow should this be manually tested?
With the eyes.