Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go.mod and add notes on the provenance of this package #7

Merged
merged 0 commits into from Apr 20, 2021

Conversation

nicks
Copy link
Member

@nicks nicks commented Apr 20, 2021

Hello @nicks,

Please review the following commits I made in branch nicks/rebase:

fb09a0d (2021-04-20 13:51:48 -0400)
Update go.mod and add notes on the provenance of this package

f27fd4f (2021-04-20 13:49:26 -0400)
windows: dynamically adjust the buffer size

1785776 (2021-04-20 13:49:26 -0400)
oops, i forgot how to cross-compile properly on windows

2cb9c60 (2021-04-20 13:49:26 -0400)
windows: expose support for recursive directory watches

846b32d (2021-04-20 13:49:26 -0400)
Fix debugging on macos

8a5d4ab (2021-04-20 13:49:26 -0400)
kqueue: Make watcher.Close() O(n) instead of O(n^2)

7f4cf4d (2020-04-17 14:56:12 -0700)
Fix unsafe pointer conversion (fsnotify#325)
Fix the following unsafe pointer conversion found using the Go 1.14
-d=checkptr gcflags (go1.14rc1 test -gcflags=all=-d=checkptr -v ./...)

fatal error: checkptr: unsafe pointer conversion

goroutine 68 [running]:
runtime.throw(0x5833e9, 0x23)
	runtime/panic.go:1112 +0x72 fp=0xc00030fba8 sp=0xc00030fb78 pc=0x432a32
runtime.checkptrAlignment(0xc00031f018, 0x544800, 0x1)
	runtime/checkptr.go:18 +0xb7 fp=0xc00030fbd8 sp=0xc00030fba8 pc=0x4063a7
github.com/fsnotify/fsnotify.(*Watcher).readEvents(0xc0002900f0)
	github.com/fsnotify/fsnotify/inotify.go:275 +0x457 fp=0xc00031ffd8 sp=0xc00030fbd8 pc=0x519037
runtime.goexit()
	runtime/asm_amd64.s:1375 +0x1 fp=0xc00031ffe0 sp=0xc00031ffd8 pc=0x463eb1
created by github.com/fsnotify/fsnotify.NewWatcher
	github.com/fsnotify/fsnotify/inotify.go:59 +0x1a5

Fixes fsnotify#330
45d7d09 (2020-03-11 11:35:18 -0600)
Move example usage to the readme
may resolve fsnotify#328

4bf2d1f (2019-10-11 19:07:59 -0600)
Updating the FAQ section for supportability with NFS & FUSE filesystems.
closes fsnotify#312 fsnotify#306

dc27d96 (2019-10-07 20:08:56 -0600)
drop 1.8.x from Travis CI
see fsnotify#310

fce5a44 (2019-10-07 20:08:56 -0600)
2019

ecf2c4d (2019-10-07 20:08:56 -0600)
revise editor config
tabs only for Go

0a05407 (2019-10-07 20:08:56 -0600)
Add Go modules

ab058b4 (2019-10-05 16:41:51 -0600)
readme: plan to support fanotify

924410f (2019-10-05 16:01:05 -0600)
Open files with CLOEXEC
Fix fsnotify#272

1485a34 (2019-03-12 11:14:46 -0700)
Also create epoll and pipe fds with close-on-exec (fsnotify#155) (fsnotify#219)

85de84f (2019-03-08 10:04:29 -0700)
Add windows to travis matrix

2216558 (2019-03-08 10:04:29 -0700)
Fix lint issue with error doc string

9152fb1 (2019-03-08 10:04:29 -0700)
only run golint on latest version of go

ccc981b (2018-08-30 16:02:26 -0600)
Check if channels are closed in the example (fsnotify#244)

  • Check if channels are closed in the example

  • Check if the channels are closed before printing

1f285c6 (2018-08-30 15:20:37 -0600)
darwin tests: Exchangedata is deprecated on 10.13
fsnotify#264

7b866c9 (2018-08-30 15:20:37 -0600)
travis: less verbose tests
TravisCI: skip tip

8ba2b19 (2018-08-30 14:59:23 -0600)
[fsnotify#234] t.Fatalf -> t.Errorf in go routines (fsnotify#266)
The documentation for t.FailNow (which is called by t.Fatalf) states
that it should not be called in go routines outside of the test go
routine.
70cc4a1 (2018-08-30 14:03:37 -0600)
Fix TestInotifyOverflow (fsnotify#265)

  • Queued inotify events could have been read by the test before max_queued_events was hit
    1d13583 (2018-08-30 09:48:21 -0600)
    TravisCI: updating test versions

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant