Update to build for Node.js v12

[fengmk2]

No description provided.

[fengmk2]

Need nan support Node.js 12 first nodejs/nan#849

[pipobscure]

Can you also bump the version in package.json please.

[fengmk2]

@pipobscure sure, now We have to wait till the next release of nan with support of node v12.x.

[sam-github]

I wonder if using napi instead of nan would allow faster sync with node releases?

[Flarna]

Current NAN version (2.13.2) is already supporting Node.JS 12; only part missing is update of readme but this should not block.
There are several places in fsevents@1.x where v8 API is used directly which should be changed to NAN calls.

[pipobscure]

@sam-github v2 is NAPI update to that please. Only downside is there’s no v6.x support and older v8.x releases aren’t supported either.

[sam-github]

@pipobscure I missed that this was a maintenance release of an older line, I'm glad you are maintaining v1, thanks, and I see why it is still nan-based. (And I don't use personally use fsevents, I work on maintaining node, I'm just keeping an eye on fallout from our 12.x release).

[felixfbecker]

So what is blocking this?

[pipobscure]

@felixfbecker nothing other than the fact that i have a full-time job, a family and a bunch of commitments. I’ll need to figure out what exactly the problem is and then fix it. If you want to have a go, I’m more than happy to look at pull-requests.

[felixfbecker]

Looks like Node 12 removed v8::Handle which fsevents uses facebook/create-react-app#6891 (comment)

Unfortunately I am in the same boat as you but also have zero experience with native addons / C++.

[kroleg]

Made enough changes to compile without errors #274 Tests are passing (at least in v12 on my machine)
I am not a C guy, so not sure if FSEvents::Initialize should be more like plusOne example in https://nodejs.org/api/addons.html#addons_wrapping_c_objects

[pipobscure]

Superceded by #274