fsevents @1.2.7 | @1.2.8 does not build with Node 12 #27389 #272

jwulf · 2019-04-24T15:21:38Z

Version: v12.0.0
Platform: Darwin 192-168-1-57.tpgi.com.au 18.2.0 Darwin Kernel Version 18.2.0: Mon Nov 12 20:24:46 PST 2018; root:xnu-4903.231.4~2/RELEASE_X86_64 x86_64
Subsystem:

To Reproduce:

npm i fsevents@1.2.7

or

npm i fsevents@1.2.8

../fsevents.cc:76:16: error: variable has incomplete type 'void'
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
               ^
../fsevents.cc:76:31: error: no member named 'Handle' in namespace 'v8'
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
                          ~~~~^
../fsevents.cc:76:48: error: expected '(' for function-style cast or type construction
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
                                     ~~~~~~~~~~^
../fsevents.cc:76:16: error: variable has incomplete type 'void'
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
               ^
../fsevents.cc:76:50: error: use of undeclared identifier 'exports'
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
                                                 ^
../fsevents.cc:76:58: error: expected ';' after top level declarator
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
                                                         ^
                                                         ;
../fsevents.cc:76:31: error: no member named 'Handle' in namespace 'v8'
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
                          ~~~~^
../fsevents.cc:76:48: error: expected '(' for function-style cast or type construction
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
                                     ~~~~~~~~~~^
../fsevents.cc:76:50: error: use of undeclared identifier 'exports'
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
                                                 ^
../fsevents.cc:76:58: error: expected ';' after top level declarator
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
                                                         ^
                                                         ;
20 warnings and 6 errors generated.
make: *** [Release/obj.target/fse/fsevents.o] Error 1
20 warnings and 6 errors generated.
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/opt/nvm/versions/node/v12.0.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:196:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:256:12)
gyp ERR! System Darwin 18.2.0
gyp ERR! command "/usr/local/opt/nvm/versions/node/v12.0.0/bin/node" "/usr/local/opt/nvm/versions/node/v12.0.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--module=/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/lib/binding/Release/node-v72-darwin-x64/fse.node" "--module_name=fse" "--module_path=/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/lib/binding/Release/node-v72-darwin-x64" "--napi_version=4" "--node_abi_napi=napi"
gyp ERR! cwd /Users/sitapati/workspace/SMA/smac/node_modules/fsevents
gyp ERR! node -v v12.0.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok 
make: *** [Release/obj.target/fse/fsevents.o] Error 1
node-pre-gyp ERR! build error 
node-pre-gyp ERR! stack Error: Failed to execute '/usr/local/opt/nvm/versions/node/v12.0.0/bin/node /usr/local/opt/nvm/versions/node/v12.0.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/lib/binding/Release/node-v72-darwin-x64/fse.node --module_name=fse --module_path=/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/lib/binding/Release/node-v72-darwin-x64 --napi_version=4 --node_abi_napi=napi' (1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:196:13)
node-pre-gypgyp ERR! stack     at maybeClose (internal/child_process.js:1000:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:267:5)
node-pre-gyp ERR! System Darwin 18.2.0
node-pre-gyp ERR! command "/usr/local/opt/nvm/versions/node/v12.0.0/bin/node" "/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/node_modules/node-pre-gyp/bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /Users/sitapati/workspace/SMA/smac/node_modules/fsevents
node-pre-gyp ERR!  node -v v12.0.0
node-pre-gyp ERR! node-pre-gyp -v v0.10.3
ERR!node-pre-gyp  ERR! build errornot ok 
 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/opt/nvm/versions/node/v12.0.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:196:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:256:12)
Failed to execute '/usr/local/opt/nvm/versions/node/v12.0.0/bin/node /usr/local/opt/nvm/versions/node/v12.0.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/lib/binding/Release/node-v72-darwin-x64/fse.node --module_name=fse --module_path=/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/lib/binding/Release/node-v72-darwin-x64 --napi_version=4 --node_abi_napi=napi' (1)
gyp ERR! System Darwin 18.2.0
gyp ERR! command "/usr/local/opt/nvm/versions/node/v12.0.0/bin/node" "/usr/local/opt/nvm/versions/node/v12.0.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--module=/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/lib/binding/Release/node-v72-darwin-x64/fse.node" "--module_name=fse" "--module_path=/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/lib/binding/Release/node-v72-darwin-x64" "--napi_version=4" "--node_abi_napi=napi"
gyp ERR! cwd /Users/sitapati/workspace/SMA/smac/node_modules/fsevents
gyp ERR! node -v v12.0.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok 
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.7 (node_modules/fsevents):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.7 install: `node install`
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Exit status 1

The text was updated successfully, but these errors were encountered:

alextes · 2019-04-29T13:00:59Z

See also #271 and #274 .

pipobscure · 2019-04-29T15:58:41Z

This will be fixed in #274 (hopefully shortly)

pipobscure · 2019-04-29T16:18:51Z

Just released v1.2.9 which is Node v12 compatible. Prebuilt binaries being built as we speak.

jacargentina · 2019-04-30T21:27:11Z

This is also happening on 2.0.6 @pipobscure should i open a new issue ?

pipobscure · 2019-04-30T23:15:34Z

It is absolutely impossible that thus could happen with 2.0.6 since this is a compile error and you never compile 2.0.6

Are you sure you have the right issue?

Can you create a new issue and describe exactly what the problem is?

h0jeZvgoxFepBQ2C · 2019-05-03T15:21:40Z

How can I install the new version through yarn? It still tries to install 1.2.4 for me?

GProst · 2019-05-03T15:25:55Z

@h0jeZvgoxFepBQ2C you can, for example:

Remove yarn.lock and run yarn install.
Or you can find a package in yarn.lock which has fsevents as a dependency and re-install this package (yarn remove, yarn add)

Probably there are more ways

Some of the packages we rely on (onchange -> chokidar -> fsevents for example) rely on fsevents. fsevents prior to 1.2.9 isn't Node 12 compatible. See fsevents/fsevents#272 (comment)

* Upgrade to node-sass@^4.12.0, add Node 12 support See sass/node-sass#2632 (comment) * Ensure to install fsevents 1.2.9 or higher Some of the packages we rely on (onchange -> chokidar -> fsevents for example) rely on fsevents. fsevents prior to 1.2.9 isn't Node 12 compatible. See fsevents/fsevents#272 (comment) * Remove resolution fields, keep yarn.lock changes This ensures we install fsevents@1.2.9, without making fsevents a required dependency. See #1219 (comment)

…ode 12 fsevents/fsevents#272

Summary: This yarn.lock file was regenerated by deleting the existing yarn.lock file and rerunning `yarn install`. The current `yarn.lock` file is fairly out of date and is affecting the CI servers. More specifically, fsevents@1.2.7, [referenced in yarn.lock here](https://github.com/facebook/react-native/blob/46be292f671c70aac4ecc178c96e3a2a6a3d16da/yarn.lock#L3215), [fails to compile](fsevents/fsevents#272) on node 12 or later. This causes the [yarn install step on CI to error](https://app.circleci.com/pipelines/github/facebook/react-native/7065/workflows/de2bebff-33a5-4d2e-bc73-f7f380641452/jobs/176266/parallel-runs/0/steps/0-104). This PR is being made as 1 step in getting [the RNTester detox tests running again](#30312). We can alternatively manually update the `yarn.lock` file with [the minimum needed fsevent changes](https://github.com/facebook/react-native/compare/master...MLH-Fellowship:update-yarn-lock-fsevents?expand=1#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2deL3215-L3221) if this PR changes too much. ## Changelog  [Internal] [Changed] - Bump fsevents from 1.2.7 to 1.2.13. Pull Request resolved: #30361 Test Plan: Verify yarn install step on CI is fixed. Reviewed By: hramos Differential Revision: D24910611 Pulled By: cpojer fbshipit-source-id: 45a2f25a14d368d2f464e489924b1a2befbdf784

* Upgrade to node-sass@^4.12.0, add Node 12 support See sass/node-sass#2632 (comment) * Ensure to install fsevents 1.2.9 or higher Some of the packages we rely on (onchange -> chokidar -> fsevents for example) rely on fsevents. fsevents prior to 1.2.9 isn't Node 12 compatible. See fsevents/fsevents#272 (comment) * Remove resolution fields, keep yarn.lock changes This ensures we install fsevents@1.2.9, without making fsevents a required dependency. See react-static/react-static#1219 (comment)

jwulf mentioned this issue Apr 24, 2019

fsevents @1.2.7 | @1.2.8 does not build with Node 12 nodejs/node#27389

Closed

lovell mentioned this issue Apr 27, 2019

Problem installing sharp macos 10 lovell/sharp#1673

Closed

pipobscure closed this as completed Apr 29, 2019

idanwork mentioned this issue Apr 30, 2019

Postinstall (electron-builder install-app-deps) fails with 5.0.0 beta versions of Electron on Linux electron-userland/electron-builder#3703

Closed

nddery mentioned this issue Jun 10, 2019

Node 12 (stable) support react-static/react-static#1219

Merged

9 tasks

sharkinsspatial mentioned this issue Jun 23, 2019

yarn build failure sat-utils/sat-api-browser#20

Closed

lcoenen mentioned this issue Aug 3, 2019

[fluence-js] unable to compile nor on Node 12 nor on 11 fluencelabs/nox#769

Closed

douglascook added a commit to douglascook/fabledLandsValet that referenced this issue Oct 12, 2019

Specify fsevents dependency so we have a version that installs with n…

1e6f159

…ode 12 fsevents/fsevents#272

mkcode mentioned this issue Nov 10, 2020

Update yarn.lock facebook/react-native#30361

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fsevents @1.2.7 | @1.2.8 does not build with Node 12 #27389 #272

fsevents @1.2.7 | @1.2.8 does not build with Node 12 #27389 #272

jwulf commented Apr 24, 2019

alextes commented Apr 29, 2019

pipobscure commented Apr 29, 2019

pipobscure commented Apr 29, 2019

jacargentina commented Apr 30, 2019 •

edited

pipobscure commented Apr 30, 2019

h0jeZvgoxFepBQ2C commented May 3, 2019

GProst commented May 3, 2019 •

edited

fsevents @1.2.7 | @1.2.8 does not build with Node 12 #27389 #272

fsevents @1.2.7 | @1.2.8 does not build with Node 12 #27389 #272

Comments

jwulf commented Apr 24, 2019

To Reproduce:

alextes commented Apr 29, 2019

pipobscure commented Apr 29, 2019

pipobscure commented Apr 29, 2019

jacargentina commented Apr 30, 2019 • edited

pipobscure commented Apr 30, 2019

h0jeZvgoxFepBQ2C commented May 3, 2019

GProst commented May 3, 2019 • edited

jacargentina commented Apr 30, 2019 •

edited

GProst commented May 3, 2019 •

edited