fsevents @1.2.7 | @1.2.8 does not build with Node 12 #27389

jwulf · 2019-04-24T15:19:24Z

Version: v12.0.0
Platform: Darwin 192-168-1-57.tpgi.com.au 18.2.0 Darwin Kernel Version 18.2.0: Mon Nov 12 20:24:46 PST 2018; root:xnu-4903.231.4~2/RELEASE_X86_64 x86_64
Subsystem:

To Reproduce:

npm i fsevents@1.2.7

or

npm i fsevents@1.2.8

../fsevents.cc:76:16: error: variable has incomplete type 'void'
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
               ^
../fsevents.cc:76:31: error: no member named 'Handle' in namespace 'v8'
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
                          ~~~~^
../fsevents.cc:76:48: error: expected '(' for function-style cast or type construction
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
                                     ~~~~~~~~~~^
../fsevents.cc:76:16: error: variable has incomplete type 'void'
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
               ^
../fsevents.cc:76:50: error: use of undeclared identifier 'exports'
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
                                                 ^
../fsevents.cc:76:58: error: expected ';' after top level declarator
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
                                                         ^
                                                         ;
../fsevents.cc:76:31: error: no member named 'Handle' in namespace 'v8'
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
                          ~~~~^
../fsevents.cc:76:48: error: expected '(' for function-style cast or type construction
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
                                     ~~~~~~~~~~^
../fsevents.cc:76:50: error: use of undeclared identifier 'exports'
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
                                                 ^
../fsevents.cc:76:58: error: expected ';' after top level declarator
void FSEvents::Initialize(v8::Handle<v8::Object> exports) {
                                                         ^
                                                         ;
20 warnings and 6 errors generated.
make: *** [Release/obj.target/fse/fsevents.o] Error 1
20 warnings and 6 errors generated.
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/opt/nvm/versions/node/v12.0.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:196:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:256:12)
gyp ERR! System Darwin 18.2.0
gyp ERR! command "/usr/local/opt/nvm/versions/node/v12.0.0/bin/node" "/usr/local/opt/nvm/versions/node/v12.0.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--module=/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/lib/binding/Release/node-v72-darwin-x64/fse.node" "--module_name=fse" "--module_path=/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/lib/binding/Release/node-v72-darwin-x64" "--napi_version=4" "--node_abi_napi=napi"
gyp ERR! cwd /Users/sitapati/workspace/SMA/smac/node_modules/fsevents
gyp ERR! node -v v12.0.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok 
make: *** [Release/obj.target/fse/fsevents.o] Error 1
node-pre-gyp ERR! build error 
node-pre-gyp ERR! stack Error: Failed to execute '/usr/local/opt/nvm/versions/node/v12.0.0/bin/node /usr/local/opt/nvm/versions/node/v12.0.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/lib/binding/Release/node-v72-darwin-x64/fse.node --module_name=fse --module_path=/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/lib/binding/Release/node-v72-darwin-x64 --napi_version=4 --node_abi_napi=napi' (1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:196:13)
node-pre-gypgyp ERR! stack     at maybeClose (internal/child_process.js:1000:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:267:5)
node-pre-gyp ERR! System Darwin 18.2.0
node-pre-gyp ERR! command "/usr/local/opt/nvm/versions/node/v12.0.0/bin/node" "/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/node_modules/node-pre-gyp/bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /Users/sitapati/workspace/SMA/smac/node_modules/fsevents
node-pre-gyp ERR!  node -v v12.0.0
node-pre-gyp ERR! node-pre-gyp -v v0.10.3
ERR!node-pre-gyp  ERR! build errornot ok 
 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/opt/nvm/versions/node/v12.0.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:196:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:256:12)
Failed to execute '/usr/local/opt/nvm/versions/node/v12.0.0/bin/node /usr/local/opt/nvm/versions/node/v12.0.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/lib/binding/Release/node-v72-darwin-x64/fse.node --module_name=fse --module_path=/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/lib/binding/Release/node-v72-darwin-x64 --napi_version=4 --node_abi_napi=napi' (1)
gyp ERR! System Darwin 18.2.0
gyp ERR! command "/usr/local/opt/nvm/versions/node/v12.0.0/bin/node" "/usr/local/opt/nvm/versions/node/v12.0.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--module=/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/lib/binding/Release/node-v72-darwin-x64/fse.node" "--module_name=fse" "--module_path=/Users/sitapati/workspace/SMA/smac/node_modules/fsevents/lib/binding/Release/node-v72-darwin-x64" "--napi_version=4" "--node_abi_napi=napi"
gyp ERR! cwd /Users/sitapati/workspace/SMA/smac/node_modules/fsevents
gyp ERR! node -v v12.0.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok 
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.7 (node_modules/fsevents):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.7 install: `node install`
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Exit status 1

The text was updated successfully, but these errors were encountered:

jwulf · 2019-04-24T15:22:10Z

Opened in fsevents as fsevents/fsevents#272. Which is the right repo to report this?

jwulf · 2019-04-24T15:24:05Z

Looks like it could be fixed by fsevents/fsevents#271

targos · 2019-04-24T15:27:22Z

This should be fixed in the fsevents repo.

Talbot3 · 2019-04-24T23:45:59Z

When to fix it

Kronenberg · 2019-05-27T06:14:49Z

Remove yarn.lock and run yarn install.
Or you can find a package in yarn.lock which has fsevents as a dependency and re-install this package (yarn remove, yarn add)

Its should help

amitbravo · 2019-05-29T08:46:12Z

@Kronenberg It did work :)

willgriffiths · 2019-08-26T22:31:33Z

Another fix:
You can use the resolutions key in your package.json to enforce fsevents >1.2.9 for your repo.

E.g.

....
  "resolutions": {
    "**/fsevents": "^1.2.9"
  }
...

More info here.

nodejs/node#27389 (comment) sass/node-sass#2632 (comment)

targos added the wrong repo Issues that should be opened in another repository. label Apr 24, 2019

targos closed this as completed Apr 24, 2019

This was referenced Sep 29, 2019

npm install fails on Node 12 excellalabs/unanet-summarizer#122

Closed

#122 Pin fsevents version to minimum 1.2.9 excellalabs/unanet-summarizer#123

Merged

ka2jun8 mentioned this issue Nov 17, 2019

portal-embed-demo: it is failed to build by fsevents@1.2.8 on Node v12 WICG/portals#161

Open

danoc mentioned this issue Dec 17, 2019

Upgrade fsevents to fix Node 12 issue and force use of Node 12 thumbtack/thumbprint#596

Merged

holylovelqq mentioned this issue Jan 7, 2020

【笔记】项目开发过程中的依赖模块升级--yarn resolution holylovelqq/vue-element-moment-xss-axios-router-vuex#3

Open

jamesdh mentioned this issue Feb 8, 2020

make init fails with gyp/FSEvents build failure when using node 12 on MacOS plouc/nivo#860

Closed

This was referenced Mar 1, 2020

yarn install breaks on node12 LTS rails/rails#38612

Closed

Update package.json to install fsevents on node >= 12 rails/rails#38615

Merged

dalehille mentioned this issue Mar 18, 2020

Tutorial does not work on mac with latest node. carbon-design-system/carbon-tutorial#3723

Closed

PierreMarieRiviere mentioned this issue Apr 28, 2020

"callback already called" error trufflesuite/truffle#3008

Closed

1 task

joeyAghion mentioned this issue Jun 10, 2020

Attempt to upgrade to node v12 artsy/kaws#238

Merged

joshkel added a commit to rk-squared/rk-squared.github.io that referenced this issue Jun 13, 2020

Update fsevents and node-sass for Node 12

de7c880

nodejs/node#27389 (comment) sass/node-sass#2632 (comment)

xc1427 mentioned this issue Sep 22, 2020

feat: upgrade immer version to 7.x dvajs/dva#2380

Merged

1 task

arelra mentioned this issue Apr 28, 2021

Fix and update TypeScript Harness guardian/coding-exercise-project#58

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fsevents @1.2.7 | @1.2.8 does not build with Node 12 #27389

fsevents @1.2.7 | @1.2.8 does not build with Node 12 #27389

jwulf commented Apr 24, 2019

jwulf commented Apr 24, 2019

jwulf commented Apr 24, 2019

targos commented Apr 24, 2019

Talbot3 commented Apr 24, 2019

Kronenberg commented May 27, 2019

amitbravo commented May 29, 2019

willgriffiths commented Aug 26, 2019

fsevents @1.2.7 | @1.2.8 does not build with Node 12 #27389

fsevents @1.2.7 | @1.2.8 does not build with Node 12 #27389

Comments

jwulf commented Apr 24, 2019

To Reproduce:

jwulf commented Apr 24, 2019

jwulf commented Apr 24, 2019

targos commented Apr 24, 2019

Talbot3 commented Apr 24, 2019

Kronenberg commented May 27, 2019

amitbravo commented May 29, 2019

willgriffiths commented Aug 26, 2019