Skip to content
This repository has been archived by the owner on Mar 24, 2024. It is now read-only.

Enable Chromatic #216

Merged
merged 1 commit into from Mar 11, 2021
Merged

Enable Chromatic #216

merged 1 commit into from Mar 11, 2021

Conversation

amacneil
Copy link
Contributor

@amacneil amacneil commented Mar 11, 2021

Alternative to reg-suit, currently running in parallel.

  • Chromatic job took 6m24s to build versus 9m15s for reg-suit
  • Nice UI to review and specifically accept each changed story
  • Able to review components (instead of just screenshots)
  • I don't understand what is the difference between "UI Tests" and "UI Review" statuses that they put on Github. It looks like we can disable one of them, but need to figure out what their intention is first.

@reg-suit
Copy link

reg-suit bot commented Mar 11, 2021

reg-suit detected visual differences.

Check this report, and review them.

🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@amacneil amacneil force-pushed the chromatic branch 9 times, most recently from 4b2ab4a to 9396dd4 Compare March 11, 2021 09:53
@@ -132,6 +134,7 @@
"@types/ws": "7.4.0",
"@wojtekmaj/enzyme-adapter-react-17": "0.4.1",
"argparse": "2.0.1",
"chromatic": "github:amacneil/chromatic-cli#detectyarn",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amacneil amacneil marked this pull request as ready for review March 11, 2021 10:08
@amacneil amacneil merged commit 4968b89 into main Mar 11, 2021
@amacneil amacneil deleted the chromatic branch March 11, 2021 10:09
GRBadyal pushed a commit to GhostRoboticsDev/studio that referenced this pull request Apr 24, 2023
…#216)

### Public-Facing Changes

- Add parameter to include hidden topics and services (not included by
default)

### Description
Adds the new parameter `include_hidden` which controls if hidden topics
or services are advertised.

From
https://design.ros2.org/articles/topic_and_service_names.html#hidden-topic-or-service-names:

> Any topic or service name that contains any tokens (either namespaces
or a topic or service name) that start with an underscore (_) will be
considered hidden and tools may not show them unless explicitly asked.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant