This repository has been archived by the owner on Mar 24, 2024. It is now read-only.
Run CI on PR merge commit #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amacneil
force-pushed
the
adrian/pr-merge-commits
branch
from
3b2a989
to
721a67c
Compare
Closed
amacneil
force-pushed
the
adrian/pr-merge-commits
branch
from
721a67c
to
72db354
Compare
amacneil
force-pushed
the
adrian/pr-merge-commits
branch
from
72db354
to
1c7e834
Compare
amacneil
force-pushed
the
adrian/pr-merge-commits
branch
from
1c7e834
to
a0f2c7b
Compare
amacneil
force-pushed
the
adrian/pr-merge-commits
branch
from
a0f2c7b
to
186be45
Compare
amacneil
force-pushed
the
adrian/pr-merge-commits
branch
from
186be45
to
740f550
Compare
amacneil
force-pushed
the
adrian/pr-merge-commits
branch
from
740f550
to
f1874bb
Compare
amacneil
force-pushed
the
adrian/pr-merge-commits
branch
from
f1874bb
to
3f7c4d9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
None
Description
PRs submitted from a fork repo don't have a valid
github.event.pull_request.head.ref. For example #1524 failed with:Determining the checkout info /usr/bin/git branch --list --remote origin/feature/add_web_build_command /usr/bin/git tag --list feature/add_web_build_command Error: A branch or tag with the name 'feature/add_web_build_command' could not be foundIt's possible this could be fixed by checking out
head.shainstead ofhead.ref. However, we originally switched to the head commit because Chromatic claimed to need it, but I'm fairly confident that is not the case.There are also advantages to testing the PR merge commit (PR merged with latest main) - it means the likelihood of a CI failure post-merge is reduced.
Therefore, switching back to using Github's default behavior. There is still some outstanding work to make PRs work completely from fork repos (Chromatic token isn't accessible - see #1608), but this at least gets us one step closer.
Closes #1626
Closes #1627